Bug 431045

Summary:	Nickname with backslash gets URL-escaped when clicking it in the ircview
Product:	[Applications] konversation	Reporter:	Nicolás Alvarez <nalvarez>
Component:	general	Assignee:	Peter Simonsson <peter.simonsson>
Status:	RESOLVED FIXED
Severity:	normal	CC:	peter.simonsson
Priority:	NOR
Version First Reported In:	1.7.5
Target Milestone:	---
Platform:	Debian stable
OS:	Linux
Latest Commit:	https://invent.kde.org/network/konversation/commit/eb63cf307ec9e1de4b1a09835fd36e57c189df68	Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicolás Alvarez 2021-01-02 02:13:36 UTC

SUMMARY
If I click on a nickname containing a backslash, the backslash gets URL-escaped in the private message tab, so private messages don't actually work.

STEPS TO REPRODUCE
1. Have a user with a backslash on their name (eg. "kline\0") say something in the channel
2. Click their nickname in the ircview
3. Private message tab opens for "kline%5C0"
4. Sending a private message on that tab shows "kline%5C0 no such nick/channel"

EXPECTED RESULT
Using /query kline\0 or clicking on the user in the nick list works correctly, opening a privmsg tab for "kline\0". Clicking the user's name in the ircview should do the same and not URL-escape the backslash.

SOFTWARE/OS VERSIONS
Debian Linux 10
Konversation 1.7.5
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3 (xcb)

I have not tried if the bug persists in 1.7.7.

Comment 1 Bug Janitor Service 2021-01-02 09:17:26 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/konversation/-/merge_requests/43

Comment 2 Peter Simonsson 2021-01-03 07:31:08 UTC

Git commit eb63cf307ec9e1de4b1a09835fd36e57c189df68 by Peter Simonsson.
Committed on 03/01/2021 at 06:56.
Pushed by psn into branch 'release/20.12'.

Handle \ in nicks when opening new query in ircview

M  +2    -0    src/viewer/ircview.cpp

https://invent.kde.org/network/konversation/commit/eb63cf307ec9e1de4b1a09835fd36e57c189df68