Bug 430605

Summary: Bug : Deselecting a selection has often a long processing time(can have to wait for up to 30s or more before it finishes)
Product: [Applications] krita Reporter: stephen <tgdev001>
Component: Tools/SelectionAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED NOT A BUG    
Severity: normal CC: halla, tamtamy.tymona
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description stephen 2020-12-20 02:28:59 UTC
SUMMARY
This bug regards the selection tools.
Quite often, after making a selection and moving its content, 
de-selecting afterwards take too much time for some reason I
don't know.

STEPS TO REPRODUCE
1. Have some painted pixels in a paint layer
2. Use the freehand selection tool to draw a selection around the pixels
3. Move the selected pixels a bit with the Move tool or by using the
transform tool.
4. De-select the selection with CTRL+D

OBSERVED RESULT
Not all the time but often, the selection still stays active
for about more or less than 30 seconds before going away.

EXPECTED RESULT
Instantaneous deselection.

Windows: 10 1909

ADDITIONAL INFORMATION
Krita version used : 4.4.3 alpha(git 2db646c)
Comment 1 Tiar 2021-01-11 14:37:11 UTC
What size was your canvas? Can you maybe make a video?

I cannot reproduce it. It's always instant on my system.

---

Krita

 Version: 5.0.0-prealpha (git 16d6f8a)
 Languages: en_US, en, en_US, en, en_US, en, pl_PL, pl, pl_PL, pl
 Hidpi: true

Qt

  Version (compiled): 5.11.1
  Version (loaded): 5.11.1

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 5.3.7-050307-generic
  Pretty Productname: Linux Mint 19.3
  Product Type: linuxmint
  Product Version: 19.3
  Desktop: X-Cinnamon
Comment 2 Bug Janitor Service 2021-01-26 04:33:27 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 stephen 2021-02-03 15:39:46 UTC
(In reply to Tiar from comment #1)
> What size was your canvas? Can you maybe make a video?
> 
> I cannot reproduce it. It's always instant on my system.

I am on Windows 10. Not Linux. 
As for the additional information, it happens at random just after you apply a transform or move operation on the contained pixels in the selection area. Then try to deselect afterwards using CTRL+D.
When it happens, selection continue to stay still for a while and you're temporarily stuck with it. 
Sometimes there's no way to cancel it even by using CTRL+Z to undo.
Which makes me think about something. 
If some operations are meant to force the user to wait, then at least, provide a dialog window with a progress bar or progress gauge showing the percentage of the progress of a given operation or task.
Comment 4 Tiar 2021-02-03 15:44:06 UTC
I guess that might be because it's waiting for the transformation to finish.
Comment 5 stephen 2021-02-05 13:39:55 UTC
(In reply to Tiar from comment #4)
> I guess that might be because it's waiting for the transformation to finish.

Then optimizations are awaited. Better ergonomics as well : a loading gauge that shows the progress of the operation from 0 to 100% before allowing the user to interact with the app again.
The chances for the bug to happen are high when you quickly move pixels in a selected area to a different position then immediately deselect.
Comment 6 stephen 2021-02-05 20:05:48 UTC
(In reply to Tiar from comment #4)
> I guess that might be because it's waiting for the transformation to finish.

It's official.
The long and very long and unbearable delay always and always happens after you move the content of a selection area. 100% frustrating moment. 
And other than this, moving the contained pixels in the selection area leaves glitches on the canvas if you move continuously without stopping. 

Krita really really should be optimized.

* The brush engine should be optimized to render faster with very big pixel size(100-2000 pixels)

* There shouldn't be any artifact/glitch when changing colors through adjustment filters, while hiding/showing a layer, while painting...etc

* Any selection tool, for a move operation should only target the contained non null pixels in a selection area and thus reduce the size of the selection area...

* No more artifacts/glitches/super long delays while operating transformations on pixels in a layer(always target big data size to optimize things, a 5000x5000 canvas resolution is recommended for things like that).

Please, optimize Krita much much deeper to improve workflow speed for professional artists and Krita users in general. We need this to happen.
Comment 7 Halla Rempt 2021-02-05 21:15:08 UTC
Performance complaints are not suitable for bug reports. Closing this.
Comment 8 stephen 2021-02-06 00:25:29 UTC
(In reply to Halla Rempt from comment #7)
> Performance complaints are not suitable for bug reports. Closing this.

Have you checked whether it's a bug or not very first ?
Reopening this. Please, close this after you have checked.
Comment 9 Halla Rempt 2021-02-06 09:42:42 UTC
As maintainer of Krita I have determined that your report does not contain useful information that can be used to resolve an in issue in Krita's code, so it's not a bug report.

Do not reopen bugs if you're not a developer: if you do that again, I will ask sysadmin to remove your bugzilla account.
Comment 10 stephen 2021-02-06 09:54:00 UTC
(In reply to Halla Rempt from comment #9)
> As maintainer of Krita I have determined that your report does not contain
> useful information that can be used to resolve an in issue in Krita's code,
> so it's not a bug report.
> 
> Do not reopen bugs if you're not a developer: if you do that again, I will
> ask sysadmin to remove your bugzilla account.

Fine.
I'd like to ask. About the glitches/artifacts that continuously appear on the canvas while moving sleceted raster data, is this not a bug as well ?