| Summary: | There is no lock button in animation-related dockers | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tiar <tamtamy.tymona> |
| Component: | Animation | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | emmetoneill.pdx, rojasreinold |
| Priority: | NOR | ||
| Version First Reported In: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Screenshot of Animation workspace on my system | ||
The icons used for dockers are located in krita/libs/widgets/pics/ folder. Git commit 6cdc0155052bd5027fe7ea6603945e92b8cc56ef by Agata Cacko. Committed on 17/12/2020 at 14:30. Pushed by tymond into branch 'master'. Fix ugly icons on Animation (and maybe other) dockers Before this commit, KisUtilityTitleBar would use style-default close and float button. They are a bit ugly though. This commit changes the icons to the ones that are used for other dockers. M +5 -2 libs/ui/widgets/kis_utility_title_bar.cpp https://invent.kde.org/graphics/krita/commit/6cdc0155052bd5027fe7ea6603945e92b8cc56ef I changed the icons, so now I'm converting this report to wishlist. The change that needs to be done should be in kis_utility_title_bar.cpp . I'm not sure if this is even needed though. I see all other dockers go their lock icons recently, so I guess users do want locks, there is no reason to not let Animation dockers have them, too. Animation dockers now have lock button from https://invent.kde.org/graphics/krita/-/merge_requests/2083 Closing as resolved. |
Created attachment 134131 [details] Screenshot of Animation workspace on my system SUMMARY Other dockers use neat new icons but the Animation dockers (Animation Timeline and Animation Curves) use the old ones, because they use custom top bars. STEPS TO REPRODUCE 1. Open Krita. 2. Switch to Animation workspace. OBSERVED RESULT - ugly icons for float and close - no icon for lock EXPECTED RESULT - lock icon for Animation dockers - neat other icons Note: My Krita is after the commit that adds nice icons (in svg form) for lock and float docker buttons. SOFTWARE/OS VERSIONS Krita Version: 5.0.0-prealpha (git 55546aa) Languages: en_US, en, en_US, en, en_US, en, pl_PL, pl, pl_PL, pl Hidpi: true Qt Version (compiled): 5.11.1 Version (loaded): 5.11.1