Bug 430302

Summary:	Adjust size of the dialogue “Krita System Information”
Product:	[Applications] krita	Reporter:	Markus Elfring <Markus.Elfring>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, paul
Priority:	NOR
Version First Reported In:	4.4.1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot of a questionable size according to the dialogue “System Information” by Krita 4.4.1

Description Markus Elfring 2020-12-12 14:39:10 UTC

SUMMARY
I suggest to take another look at a specific help dialogue.

STEPS TO REPRODUCE
Select the entry “Show system information for bug reports.” from the menu “Help”.

OBSERVED RESULT
This dialogue is so high that the buttons below the text field are only partly visible.

EXPECTED RESULT
* Buttons should be completely displayed besides other widgets (without manual window resizing).
* Please improve the size determination.

ADDITIONAL INFORMATION
https://docs.krita.org/en/reference_manual/main_menu/help_menu.html

Comment 1 Halla Rempt 2020-12-12 14:59:14 UTC

Which window manager are you using? By default and intentionally, we use availableHeight(), and if that height isn't actually available, that might be a bug in the window manager.

Btw, it would be much, much more useful to provide the contents of exactly that dialog as an attachment to this bug than to point at the manual.

Comment 2 Markus Elfring 2020-12-12 15:15:19 UTC

Created attachment 134034 [details]
Screenshot of a questionable size according to the dialogue “System Information” by Krita 4.4.1

Comment 3 Halla Rempt 2020-12-12 15:17:51 UTC

So, what window manager are you using?

Comment 4 Markus Elfring 2020-12-12 15:20:44 UTC

(In reply to Boudewijn Rempt from comment #1)
> Which window manager are you using?

I am trying the program out in a XFCE 4.14.2 session at the moment.

Comment 5 Paul 2021-02-07 08:58:14 UTC

I was able to reproduce this building 515589e with a fresh install of Ubuntu 20.04 running Xfce 4.14.

Poking around in the source of dlg_buginfo.cpp, QGuiApplication::primaryScreen()->availableGeometry() calling .height() gave me 773 with the xfce's Panel in the way, 800 when I moved it. So I think it's reporting the expected value.

It is passing this value to resize() on the Dialog. I believe this sets the size excluding the window frame. Most OSes seem to prevent dialog boxes from being too big. Xfce doesn't have that constraint which is causing this issue.

Comment 6 Paul 2021-02-09 08:35:12 UTC

https://invent.kde.org/graphics/krita/-/merge_requests/695

This should address the issue.

Comment 7 Halla Rempt 2021-02-09 10:27:13 UTC

This got merged