Bug 430281

Summary: When you first try to apply the halftone filter, the screentone shape is set to 'Round' (on the filter window), but it's 'diamond' on the canvas.
Product: [Applications] krita Reporter: acc4commissions
Component: FiltersAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73
Priority: NOR    
Version First Reported In: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: All   
Latest Commit: https://invent.kde.org/graphics/krita/commit/0339b6fa67c98a5287dbe55a991217695db84c30 Version Fixed In:
Sentry Crash Report:

Description acc4commissions 2020-12-11 23:00:37 UTC 
SUMMARY
git 2db646c

It returns back to normal after touching the option. 

STEPS TO REPRODUCE
1. Make a layer with any contents.
2. Filter -> Halftone

OBSERVED RESULT
The screentone shape is set to 'Round' (on the filter window), but it's 'diamond' on the canvas.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Sometimes the halftone filter doesn't apply (which means, it doesn't make any difference to the layer), but I can't catch exactly when it happens.
Comment 1 acc4commissions 2020-12-13 23:05:00 UTC 
The problem I mentioned in the ADDITIONAL INFORMATION section was this case, technically not a bug : https://krita-artists.org/t/halftone-filter-request/15563
Comment 2 Bug Janitor Service 2021-07-27 12:13:45 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/977
Comment 3 Dmitry Kazakov 2021-07-28 06:03:17 UTC 
Git commit 0339b6fa67c98a5287dbe55a991217695db84c30 by Dmitry Kazakov.
Committed on 28/07/2021 at 06:02.
Pushed by dkazakov into branch 'master'.

Make default configuration of the Halftone filter correspond to global defaults

It basically switches default interpolation from 'sine' to 'linear'.

The bug in question is not really correct. The default halftone shape
is **not** diamond. Instead, it is round with sine interpolation. But
when the user switches to any other shape and returns back to round,
then the interpolation automatically resets into linear. That is extremely
confusing.

This patch just ensures that linear mode is used as default all
the time.

M  +4    -2    plugins/filters/halftone/KisHalftoneFilter.cpp

https://invent.kde.org/graphics/krita/commit/0339b6fa67c98a5287dbe55a991217695db84c30