Bug 430137

Summary:	File conflict dialog: clarify "Continue"
Product:	[Applications] digikam	Reporter:	Mike Morrison <mike>
Component:	AdvancedRename-dialog	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	7.2.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/c89d4c36b419efc4aa6af85b1aeff731e7eaf811	Version Fixed In:	7.5.0
Sentry Crash Report:

Description Mike Morrison 2020-12-08 02:53:23 UTC

In the dialog which asks "What action is applied in the event of a file conflict?", the buttons read "Cancel", "Continue", "Overwrite automatically", "Rename automatically". What does "Continue" do? Is it what other UIs (e.g. Windows and Ubuntu file managers) call "Skip"? That is, don't move the conflicting files, but do move the non-conflicting files?

If so, "Skip" would be clearer and more familiar to users than "Continue". "Continue" generally emphasizes action (usually in a "Continue/Cancel" binary choice), whereas the "Skip" behavior is one of non-action (don't act at all on the conflicting files).

SOFTWARE/OS VERSIONS
Ubuntu 20.10
digikam-7.2.0-beta2-20201202T061220-x86-64.appimage
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2

Comment 1 Maik Qualmann 2020-12-08 07:44:14 UTC

Hmm, technically it's actually a "Continue". Before a file operation has been carried out, this dialog recognizes whether any conflicts will occur. If you choose Cancel, nothing has actually been changed. "Continue" actually tries to copy/move a file that is duplicated and generates an error entry in the system notification if there are problems. For me, "continue" is currently OK.

Maik

Comment 2 Mike Morrison 2020-12-08 18:48:46 UTC

That makes sense when one already knows how digiKam is going to behave. But for a user seeing this dialog for the first time, they are going to see the other 2 buttons which describe what will happen with the conflicting files:

"Rename automatically": conflicting files will be renamed.
"Overwrite automatically": conflicting files will be overwritten.
"Continue": continue and do what? what will happen to the conflicting files? will I lose them?

Even though the "Continue" button does technically continue, and will display error notifications for each conflicting file, the user doesn't know that ahead of time, and the ultimate effect with regard to the conflicting files is that they will be skipped.

I feel that a new user arriving with experience from OS file managers' use of the word "Skip" for this behavior will intuitively understand "Skip", because it creates a parallel comparison to the meaning of the "Rename" and "Overwrite" buttons, by stating specifically in each case what will happen to the conflicting files:

"Rename automatically": Conflicting files will be renamed.
"Overwrite automatically": Conflicting files will be overwritten.
"Skip": Conflicting files will be skipped.

Comment 3 caulier.gilles 2022-01-03 05:55:31 UTC

Git commit c89d4c36b419efc4aa6af85b1aeff731e7eaf811 by Gilles Caulier.
Committed on 03/01/2022 at 05:52.
Pushed by cgilles into branch 'master'.

be more explicit with options available in DIO rename dialog.
Rename Continue button by Skip
Options are now homogenous with the rest of renaming features in digiKam (Import and BQM)
FIXED-In: 7.5.0

M  +1    -1    NEWS
M  +7    -4    core/libs/database/utils/ifaces/dio.cpp

https://invent.kde.org/graphics/digikam/commit/c89d4c36b419efc4aa6af85b1aeff731e7eaf811