| Summary: | Slider fill reversed on RTL | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-qqc2-desktop-style | Reporter: | ttv200 |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahiemstra, kde, nate, noahadvs, plasma-bugs, zayed.alsaidi |
| Priority: | NOR | Keywords: | rtl |
| Version: | 5.85.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze/commit/b51316269ff02c84648667df97563bacd2538b6c | Version Fixed In: | 5.25.1 |
| Sentry Crash Report: | |||
| Attachments: | the bug | ||
|
Description
ttv200
2020-12-07 08:04:25 UTC
Created attachment 133911 [details]
the bug
*** Bug 368605 has been marked as a duplicate of this bug. *** This bug is annoying for RTL users. However, it is a common for all application that use Kirigami Controls.Slider. This issue appears to have been fixed in the PlasmaComponents3 slider at some point along the way; moving to qqc2-desktop-style where I can still reproduce the issue. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/133 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/134 A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/223 A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/224 Git commit e8b1d4aa47daf99041332f43c29fabdf70f25004 by Jan Blackquill. Committed on 04/06/2022 at 00:00. Pushed by cblack into branch 'master'. kstyle: fix qqc2 desktop style sliders in RtL We don't do any mirroring of the slider groove rects or tickmarks based on layout direction, and this causes qqc2-desktop-style sliders to render in the wrong direction. Swapping the leftRect and the rightRect when option->direction == Qt::RightToLeft fixes this. This wasn't broken with QWidgets because QSlider relies on (ab)using the upsideDown option in order to achieve mirroring of the groove instead of option->direction, and consequently, this change doesn't affect Qt widgets apps at all. M +9 -4 kstyle/breezestyle.cpp https://invent.kde.org/plasma/breeze/commit/e8b1d4aa47daf99041332f43c29fabdf70f25004 Git commit c7bfd1c728c603464cab9a43a0627a82d1ab0933 by Jan Blackquill. Committed on 04/06/2022 at 00:01. Pushed by cblack into branch 'Plasma/5.25'. kstyle: fix qqc2 desktop style sliders in RtL We don't do any mirroring of the slider groove rects or tickmarks based on layout direction, and this causes qqc2-desktop-style sliders to render in the wrong direction. Swapping the leftRect and the rightRect when option->direction == Qt::RightToLeft fixes this. This wasn't broken with QWidgets because QSlider relies on (ab)using the upsideDown option in order to achieve mirroring of the groove instead of option->direction, and consequently, this change doesn't affect Qt widgets apps at all. (cherry picked from commit e8b1d4aa47daf99041332f43c29fabdf70f25004) M +9 -4 kstyle/breezestyle.cpp https://invent.kde.org/plasma/breeze/commit/c7bfd1c728c603464cab9a43a0627a82d1ab0933 Git commit 2bf9fc4c7be280e2b77f7c150855e0fca0b80d9a by Nate Graham, on behalf of ivan tkachenko. Committed on 13/06/2022 at 13:59. Pushed by ngraham into branch 'master'. KStyle: Fix QQC2 ProgressBar desktop style in RTL layout direction M +10 -6 kstyle/breezestyle.cpp https://invent.kde.org/plasma/breeze/commit/2bf9fc4c7be280e2b77f7c150855e0fca0b80d9a Git commit b51316269ff02c84648667df97563bacd2538b6c by Nate Graham, on behalf of ivan tkachenko. Committed on 13/06/2022 at 14:07. Pushed by ngraham into branch 'Plasma/5.25'. KStyle: Fix QQC2 ProgressBar desktop style in RTL layout direction (cherry picked from commit 2bf9fc4c7be280e2b77f7c150855e0fca0b80d9a) M +10 -6 kstyle/breezestyle.cpp https://invent.kde.org/plasma/breeze/commit/b51316269ff02c84648667df97563bacd2538b6c |