Bug 429715

Summary:	When importing with the rename function, 'import selected' does not import files
Product:	[Applications] digikam	Reporter:	Spidermonkey <antonrosenfeld>
Component:	AdvancedRename-Import	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metzpinguin
Priority:	NOR
Version:	7.1.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/a997ab334e9aeb87b0249259fb1f7da1f4019f95	Version Fixed In:	7.2.0
Sentry Crash Report:

Description Spidermonkey 2020-11-27 09:44:15 UTC

SUMMARY
There is a problem with the rename function when importing files from a memory card.
If I have the rename function set to rename files with a numerical sequence, then 'import selected' does not import the files. 'Import all' works. 'Import selected' only works if I choose to keep the original names of the files.


STEPS TO REPRODUCE
1. I am on Windows 10, importing files from a memory card to an external hard drive
2. If I choose rename file with a numerical sequence, then select some files on the memory card, the files are not imported - there is no response.
3. A successful import is achieved if either I choose 'select all' or choose to keep the original file names.

OBSERVED RESULT
I am not able to import files if both 'file rename' and 'import selected' is chosen. A successful import is achieved if either I choose 'select all' or choose to keep the original file names.

EXPECTED RESULT
I would expect to be able to import selected files and rename them at the same time.

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Maik Qualmann 2020-11-27 12:30:08 UTC

I cannot reproduce the problem here in the Windows version. The renaming cannot actually have any influence, something else must trigger the problem. Please post your renaming string.

Maik

Comment 2 Spidermonkey 2020-11-27 15:09:34 UTC

Thanks for getting back so quickly.
I have just tried it again, and now it seems to be working OK, I can't reproduce the problem either. This seems strange as I have had this error over a the period of a month. I will keep an eye on the settings and see if it is something I am doing that is causing it.
FYI here is an example of the renaming string
Brandon Woods Railway Bridge #

Comment 3 Maik Qualmann 2020-11-28 15:25:01 UTC

Git commit a997ab334e9aeb87b0249259fb1f7da1f4019f95 by Maik Qualmann.
Committed on 28/11/2020 at 15:24.
Pushed by mqualmann into branch 'master'.

fix double event for update download names
FIXED-IN: 7.2.0

M  +2    -1    NEWS
M  +20   -32   core/utilities/import/main/importui.cpp

https://invent.kde.org/graphics/digikam/commit/a997ab334e9aeb87b0249259fb1f7da1f4019f95

Comment 4 Maik Qualmann 2020-11-28 15:28:28 UTC

If you click outside the thumbnails to draw a selection, a live preview of the download names is performed. This can be quite time consuming when there are thousands of files in the view. This function was unnecessarily performed twice and was therefore much slower afterwards. Should you still find a problem, open the bug again.

Maik

Comment 5 Spidermonkey 2020-11-29 15:56:03 UTC

Many thanks for your help.
Looking into it further, I think there may be a problem with my card reader on my laptop, which would explain why the problem is intermittent. Importing when connected directly to the camera works perfectly. Sorry that I didn't look at this first.