Bug 429546

Summary:	Create Event from email not respecting selected calendar
Product:	[Applications] kmail2	Reporter:	Sander van Grieken <sander>
Component:	message list	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sander van Grieken 2020-11-23 12:29:44 UTC

SUMMARY

Actually multiple UI issues with this functionality.

When selecting Create Event from email, a panel opens where you can select the calendar. I have the default Personal Calendar and also a CalDAV calendar. 

Problems: 
1. When immediately selecting Save nothing is saved, regardless of selected calendar.
2. After 1, when doing Create Event on the same email again, the description stays empty where normally the email subject is pre-filled
3. If choosing Open editor.. the selected calendar in the panel is not taken into the calendar selection combo in the popup dialog
4. If choosing the second (caldav) calendar, still the default local Personal Calendar is used to save the event


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1

ADDITIONAL INFORMATION

Comment 1 Laurent Montel 2020-11-23 12:51:40 UTC

Hi,
I confirm these problems.
I will investigate it soon.
Regards

Comment 2 Laurent Montel 2020-11-23 13:03:28 UTC

Git commit ef8daebeab50ed2d3265c79d020db5203079718b by Laurent Montel.
Committed on 23/11/2020 at 13:03.
Pushed by mlaurent into branch 'release/20.12'.

Fix select correct calendar when we open editor

M  +1    -0    plugins/messageviewerplugins/createeventplugin/eventedit.cpp

https://invent.kde.org/pim/kdepim-addons/commit/ef8daebeab50ed2d3265c79d020db5203079718b

Comment 3 Laurent Montel 2020-11-23 18:41:37 UTC

Git commit 83a83c8683e3158f2d33a07ca23f5ac7e68386ba by Laurent Montel.
Committed on 23/11/2020 at 18:41.
Pushed by mlaurent into branch 'release/20.12'.

Specify calendar when we open editor

M  +1    -0    plugins/messageviewerplugins/createtodoplugin/todoedit.cpp

https://invent.kde.org/pim/kdepim-addons/commit/83a83c8683e3158f2d33a07ca23f5ac7e68386ba

Comment 4 Laurent Montel 2020-11-24 06:16:27 UTC

Git commit dae485b54462c384c1a0d1226ef5d1bac104b771 by Laurent Montel.
Committed on 24/11/2020 at 06:15.
Pushed by mlaurent into branch 'release/20.12'.

Don't clear line edit when we finish editing

M  +0    -1    plugins/messageviewerplugins/createeventplugin/eventedit.cpp
M  +0    -1    plugins/messageviewerplugins/createnoteplugin/noteedit.cpp
M  +0    -1    plugins/messageviewerplugins/createtodoplugin/todoedit.cpp

https://invent.kde.org/pim/kdepim-addons/commit/dae485b54462c384c1a0d1226ef5d1bac104b771

Comment 5 Laurent Montel 2020-11-25 07:08:45 UTC

"4. If choosing the second (caldav) calendar, still the default local Personal Calendar is used to save the event" I can't reproduce it.

"1. When immediately selecting Save nothing is saved, regardless of selected calendar." impossibke to reproduce it.

Comment 6 Sander van Grieken 2020-11-25 08:40:04 UTC

oops, yes, I looked at the wrong day after doing a number of tests.
I verified 1 and 4 again, it looks ok.

Thanks for the quick fixes!

Comment 7 Laurent Montel 2020-11-25 09:15:14 UTC

So we can close it.
Thanks