Summary: | KIO::iconNameForUrl() returns wrong icon for mimetype | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Alexander Reinholdt <alexander.reinholdt> |
Component: | general | Assignee: | KIO Bugs <kio-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdelibs-bugs, meven.car, meven29, nate, nicolas.fella |
Priority: | NOR | ||
Version: | 5.76.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kio/commit/55465cc6639b7e5d83a9cdf30a010e0b677765c3 | Version Fixed In: | 5.77 |
Description
Alexander Reinholdt
2020-11-23 05:45:00 UTC
Can you give an example URL where this happens? Sure. Any URL of the type smb://SERVER/Path/filename.ending should yield this result. Maybe other protocols are affected, too, but I haven't checked. By the way, earlier versions of KIO did exactly what was expected. For example, if I compile Smb4K (my program) under Kubuntu 18.04, the icon name for the mimetype is correct. So, somewhere between version 5.44 and 5.76 there must have been a change that introduced this altered behavior. I just tested it with KF5 5.68. There the problem already exists. Maybe this helps. From looking at git log I'd say https://phabricator.kde.org/D27539 changed this I believe https://phabricator.kde.org/D27539 caused this. Prior to it `db.mimeTypeForUrl(url).iconName();` would become the default icon for non-local files. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/227 Git commit 55465cc6639b7e5d83a9cdf30a010e0b677765c3 by David Faure, on behalf of Méven Car. Committed on 29/11/2020 at 10:08. Pushed by dfaure into branch 'master'. KIO::iconNameForUrl: resolve icon for remote files based on name Fix a regression introduced with eb20176d1a42eebd4c6c3cbdb5dca6a854760736 FIXED-IN: 5.77 M +5 -2 autotests/kfileitemtest.cpp M +1 -1 src/core/global.cpp https://invent.kde.org/frameworks/kio/commit/55465cc6639b7e5d83a9cdf30a010e0b677765c3 |