Bug 429471

Summary: User is prompted to remove face tags from images when image count is zero 0.
Product: [Applications] digikam Reporter: José Oliver-Didier <jose_oliver>
Component: Faces-WorkflowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: metzpinguin, mike
Priority: NOR    
Version: 7.1.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/2606601e3ac67e6602d8292ebfcf91bad908565e Version Fixed In: 7.2.0
Sentry Crash Report:

Description José Oliver-Didier 2020-11-21 18:24:17 UTC 
SUMMARY
User is prompted to remove face tags from images when image count is zero 0.

STEPS TO REPRODUCE
1. Open the People Tag list
2. Look for a People Tag with zero (0) photos. 
3. Right click on the people tag with cero photos and select remove "Face Tag".
4. Click on [Yes] on "Remove face tag?" when prompted.

OBSERVED RESULT
Following confirmation of face tag removal, user is then prompted to "Remove the tag corresponding to this face tag from the images?"

EXPECTED RESULT
If there are no images with the corresponding face tag, the user should not be prompted to remove the face tag from non-existent images. The prompt seems useless.

SOFTWARE/OS VERSIONS
Windows: 10.0.19042.630
Comment 1 Maik Qualmann 2020-11-21 18:35:31 UTC 
This feature is difficult to understand for a new user, we have discussed with users it in the past and left it that way. Maybe we should change the text. This function converts a tag marked as a face tag back to a "normal" tag. This means that images to which this tag was assigned will also be removed from them.

Maik
Comment 2 Maik Qualmann 2020-11-21 18:46:07 UTC 
Git commit 2606601e3ac67e6602d8292ebfcf91bad908565e by Maik Qualmann.
Committed on 21/11/2020 at 18:45.
Pushed by mqualmann into branch 'master'.

change i18n to "Unmark Tag As Face"
FIXED-IN: 7.2.0

M  +2    -2    core/app/items/utils/contextmenuhelper.cpp

https://invent.kde.org/graphics/digikam/commit/2606601e3ac67e6602d8292ebfcf91bad908565e
Comment 3 Maik Qualmann 2020-12-05 20:27:04 UTC 
*** Bug 430053 has been marked as a duplicate of this bug. ***