Bug 429414

Summary: pyfalkon doesn't build with shiboken 5.15.2
Product: [Applications] Falkon Reporter: Antonio Rojas <arojas>
Component: extensionsAssignee: David Rosca <nowrep>
Status: RESOLVED FIXED    
Severity: normal CC: christophe
Priority: NOR    
Version First Reported In: 3.1.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/network/falkon/commit/9fac57e8feaea98b88cc0506a9e813163724d9ec Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: ok, it fails with both here.

Description Antonio Rojas 2020-11-20 20:18:23 UTC 
Shiboken 5.15.2 wraps namespaced variables [1], which means that Qz::sessionVersion is now being wrapped. But the symbol is not exported in the shared library, so PyFalkon fails to link.


[100%] Linking CXX shared module ../../../bin/plugins/PyFalkon.so
/usr/bin/ld: CMakeFiles/PyFalkon.dir/PyFalkon/qz_wrapper.cpp.o: in function `init_PyFalkonQz(_object*)':
qz_wrapper.cpp:(.text+0x105f): undefined reference to `Qz::sessionVersion'
collect2: error: ld returned 1 exit status
make[2]: *** [src/plugins/PyFalkon/CMakeFiles/PyFalkon.dir/build.make:1634: bin/plugins/PyFalkon.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:28768: src/plugins/PyFalkon/CMakeFiles/PyFalkon.dir/all] Error 2

[1] https://code.qt.io/cgit/pyside/pyside-setup.git/commit/sources?id=26a50da482c12bbbfcc8cea46aecd9f0c8305ca6
Comment 1 Bug Janitor Service 2020-11-20 20:54:40 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/falkon/-/merge_requests/11
Comment 2 Antonio Rojas 2020-11-22 11:00:53 UTC 
Git commit 9fac57e8feaea98b88cc0506a9e813163724d9ec by Antonio Rojas.
Committed on 20/11/2020 at 20:52.
Pushed by drosca into branch 'master'.

Fix PyFalkon build with shiboken 5.15.2

Prevent Qz::sessionVersion form being wrapped, since it is not exported in the shared library.

M  +1    -0    src/plugins/PyFalkon/typesystem_pyfalkon.xml

https://invent.kde.org/network/falkon/commit/9fac57e8feaea98b88cc0506a9e813163724d9ec
Comment 3 Christophe Marin 2021-07-27 07:13:38 UTC 
Out of curiosity, are you still able to build falkon with pyside 5.15.2 and llvm 12? We received a bug report about a failure + crash
Comment 4 Antonio Rojas 2021-07-27 07:37:14 UTC 
Works fine with GCC, tested with clang and fails due to -Werror=return-type (set by ECM)
Comment 5 Christophe Marin 2021-07-27 07:45:08 UTC 
Created attachment 140349 [details]
ok, it fails with both here.
Comment 6 Antonio Rojas 2021-07-27 07:56:11 UTC 
I can't reproduce that. With clang it fails to build, but bindings generation works fine.