| Summary: | New home screen MR !563 missing implementation on Android | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | amyspark <amy> |
| Component: | General | Assignee: | amyspark <amy> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | ||
| Priority: | NOR | ||
| Version First Reported In: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Android 10.x | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/fae735f3ab5f128edd0ed9229a79a58b65af5a64 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 412232, 428495 | ||
Confirming because it's broken CI since Nov 15: - https://binary-factory.kde.org/job/Krita_Nightly_Android_arm64-v8a_Build/204/execution/node/28/log/ - https://binary-factory.kde.org/job/Krita_Nightly_Android_arm64-v8a_Build/ A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/627 Git commit fae735f3ab5f128edd0ed9229a79a58b65af5a64 by L. E. Segovia. Committed on 19/12/2020 at 16:25. Pushed by rempt into branch 'master'. Fix Android-specific workarounds in Welcome page M +5 -5 libs/ui/KisWelcomePageWidget.cpp https://invent.kde.org/graphics/krita/commit/fae735f3ab5f128edd0ed9229a79a58b65af5a64 |
SUMMARY The new home screen (MR 563) did not implement the corresponding changes for Android. This breaks Krita Next or compilation from master. STEPS TO REPRODUCE 1. Build Krita from source. OBSERVED RESULT Krita fails with the following: /krita/src/libs/ui/KisWelcomePageWidget.cpp:133:5: error: use of undeclared identifier 'helpTitleLabel_2'; did you mean 'helpTitleLabel'? helpTitleLabel_2->hide(); ^~~~~~~~~~~~~~~~ helpTitleLabel /krita/android-build/krita-build/libs/ui/ui_KisWelcomePage.h:39:13: note: 'helpTitleLabel' declared here QLabel *helpTitleLabel; ^ /krita/src/libs/ui/KisWelcomePageWidget.cpp:145:5: error: use of undeclared identifier 'verticalLayout_3' verticalLayout_3->addWidget(donationLink); ^ /krita/src/libs/ui/KisWelcomePageWidget.cpp:146:5: error: use of undeclared identifier 'verticalLayout_3' verticalLayout_3->setAlignment(donationLink, Qt::AlignTop); ^ /krita/src/libs/ui/KisWelcomePageWidget.cpp:147:5: error: use of undeclared identifier 'verticalLayout_3' verticalLayout_3->setSpacing(20); ^ /krita/src/libs/ui/KisWelcomePageWidget.cpp:153:5: error: use of undeclared identifier 'verticalLayout_3' verticalLayout_3->addWidget(donationBannerImage); ^ EXPECTED RESULT Krita compiles successfully. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION