Bug 429320

Summary: 4.0.1.0 doesn't have a proper soversion.
Product: [Frameworks and Libraries] SeExpr Reporter: Antonio Rojas <arojas>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: amy
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/kseexpr/commit/997e20bb7958cdd2d1c3196133d4043a9bea13e4 Version Fixed/Implemented In:
Sentry Crash Report:

Description Antonio Rojas 2020-11-18 18:54:56 UTC 
SUMMARY
If I understand correctly, 4.0.1.0 was meant to bump the soversion from 3 to 4, but that's not the case. It gets the libversion as soversion.

> ls -l /usr/lib/libKSeExpr.*
lrwxrwxrwx 1 root root     21 nov 18 14:39 /usr/lib/libKSeExpr.so -> libKSeExpr.so.4.0.1.0
-rwxr-xr-x 1 root root 575280 nov 18 14:39 /usr/lib/libKSeExpr.so.4.0.1.0

> readelf -d /usr/lib/libKSeExpr.so.4.0.1.0
[...]
 0x000000000000000e (SONAME)             Library soname: [libKSeExpr.so.4.0.1.0]
Comment 1 Bug Janitor Service 2021-06-06 21:36:29 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/kseexpr/-/merge_requests/2
Comment 2 amyspark 2021-06-25 18:44:26 UTC 
Git commit 8cacac86fad8f4bc6d6a0d60ce739031b7cc5db8 by L. E. Segovia, on behalf of Antonio Rojas.
Committed on 06/06/2021 at 21:34.
Pushed by lsegovia into branch 'merge-requests/2'.

Fix SOVERSION

${KSeExpr_MAJOR_VERSION} is not defined, the correct variable name is ${KSeExpr_VERSION_MAJOR}

M  +3    -3    src/KSeExpr/CMakeLists.txt
M  +3    -3    src/KSeExprUI/CMakeLists.txt

https://invent.kde.org/graphics/kseexpr/commit/8cacac86fad8f4bc6d6a0d60ce739031b7cc5db8
Comment 3 amyspark 2021-06-25 18:49:11 UTC 
Git commit 997e20bb7958cdd2d1c3196133d4043a9bea13e4 by L. E. Segovia, on behalf of Antonio Rojas.
Committed on 06/06/2021 at 21:34.
Pushed by lsegovia into branch 'master'.

Fix SOVERSION

${KSeExpr_MAJOR_VERSION} is not defined, the correct variable name is ${KSeExpr_VERSION_MAJOR}

M  +3    -3    src/KSeExpr/CMakeLists.txt
M  +3    -3    src/KSeExprUI/CMakeLists.txt

https://invent.kde.org/graphics/kseexpr/commit/997e20bb7958cdd2d1c3196133d4043a9bea13e4