Bug 429290

Summary:	Impossible to modify some settings of Picture Of The Day background in Screen Locking KCM
Product:	[Applications] systemsettings	Reporter:	Patrick Silva <bugseforuns>
Component:	kcm_screenlocker	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kscreenlocker/commit/c4c2aeb7210eae08d499053e048704673e4a5910	Version Fixed/Implemented In:	5.20.4
Sentry Crash Report:

Description Patrick Silva 2020-11-18 08:20:29 UTC

STEPS TO REPRODUCE
1. open System Settings > Workspace behavior > Screen Locking, click on "Configure..."
button
2. if Wallpaper Type is not set to "Picture of The Day" yet, set this wallpaper type
and click on "Apply" button.
3. change any setting below "Wallpaper Type" combobox: notice that you can not apply the change because "Apply" button is still greyed out
3. If Wallpaper Type after the step 1 is already set to POTD, change any setting below "Wallpaper Type" combobox: again you can not apply the change because "Apply" button is still greyed out

EXPECTED RESULT
we can apply any change done in Screen Locking KCM

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.1

Comment 1 Bug Janitor Service 2020-11-18 10:29:05 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/16

Comment 2 David Redondo 2020-11-18 16:09:45 UTC

Git commit 1da23c525d5e912c1db293d8b33c52345668510e by David Redondo.
Committed on 18/11/2020 at 10:28.
Pushed by ngraham into branch 'master'.

Use QuickControls 2 StackView

The replace method of the Controls 1 stack view is not docuemnted and apparently
does not return the item.
FIXED-IN:5.20.4

M  +2    -2    kcm/package/contents/ui/WallpaperConfig.qml

https://invent.kde.org/plasma/kscreenlocker/commit/1da23c525d5e912c1db293d8b33c52345668510e

Comment 3 Nate Graham 2020-11-18 16:14:33 UTC

Git commit c4c2aeb7210eae08d499053e048704673e4a5910 by Nate Graham, on behalf of David Redondo.
Committed on 18/11/2020 at 16:13.
Pushed by ngraham into branch 'Plasma/5.20'.

Use QuickControls 2 StackView

The replace method of the Controls 1 stack view is not docuemnted and apparently
does not return the item.
FIXED-IN:5.20.4

(cherry picked from commit 1da23c525d5e912c1db293d8b33c52345668510e)

M  +2    -2    kcm/package/contents/ui/WallpaperConfig.qml

https://invent.kde.org/plasma/kscreenlocker/commit/c4c2aeb7210eae08d499053e048704673e4a5910