Bug 429256

Summary:	Separate "Move to Trash" From Other Actions in Menus
Product:	[Applications] dolphin	Reporter:	Andres Betts <anditosan1000>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	kfm-devel, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/system/dolphin/commit/b76cc3f6fa2e94857a9168068e1ea10a4a0b6a2d	Version Fixed In:	21.04
Sentry Crash Report:
Attachments:	leftclickmenu

Description Andres Betts 2020-11-17 16:18:32 UTC

SUMMARY
Given the destructive nature of the "Move to Trash" action in menus, it is recommended that they are distanced from other non-destructive actions or that it is placed next to another destructive action. This way, user are cognizant of the change they are making and are less prone to click a destructive action because of its closeness to no-destructive actions.

I offer two suggestions:

Place "Move to Trash" action in menu in between 2 separators

Place "Move to Trash" action in menu along other destructive actions like "Delete"

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2020-11-17 19:07:10 UTC

Technically "Move to trash" isn't a destructive action. The whole concept of the trash exists as a non-destructive two-step process to prevent undue destructiveness.

That said, it would probably be feasible and sensible to separate it anyway because right now it's grouped with "Rename" and "Add to Places" which have no logical connection to it whatsoever.

Comment 2 Bug Janitor Service 2020-11-17 19:17:04 UTC

A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/115

Comment 3 Nate Graham 2020-11-17 22:21:40 UTC

Git commit b76cc3f6fa2e94857a9168068e1ea10a4a0b6a2d by Nate Graham.
Committed on 17/11/2020 at 22:21.
Pushed by ngraham into branch 'master'.

Separate Delete/Move To Trash menu items in context menu

Right now these actions are in a visual group with "Rename" and "Add to
Places" which is silly as those actions have no logical connection
whatsoever to deletion.

This commits moves those items into the section above, putting them in a
more logical place and leaving the Delete/Move To Trash item in its own
section.
FIXED-IN: 21.04

M  +11   -11   src/dolphincontextmenu.cpp

https://invent.kde.org/system/dolphin/commit/b76cc3f6fa2e94857a9168068e1ea10a4a0b6a2d

Comment 4 Andres Betts 2020-11-17 22:31:17 UTC

Created attachment 133414 [details]
leftclickmenu

Here is the screenshot. I am "not" saying it "cannot" convey meaning. I am saying some items can be non-specific to their function. I am thinking that this menu needs a header.

Comment 5 Nate Graham 2020-11-17 23:30:57 UTC

Did you post this comment to the wrong bug?