| Summary: | Make it easier to switch search folder to current file | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Podagric <kde.podagric> |
| Component: | search | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | kare.sars |
| Priority: | NOR | ||
| Version First Reported In: | 20.08.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/commit/6b759fbc0782583b31140f74ab78e1ebb17ed505 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Podagric
2020-11-14 13:21:34 UTC
Thanks for the report! This is currently working as designed. The reason for not changing the folder with the changed document is that if you work in a little bit bigger project you have multiple folders and most of the time you want to search in the whole project and not only in the current file's directory. If you want to switch the search folder to the current files folder, there is the "reload" button on the right of the folder selector that loads the current files directory. This button is a bit badly placed as you need to open the "folder options" to be able to click it. At one point I had moved it to just under the search place combo... I think the reason it was moved back to it's current place was that it functionally fits better with the other buttons on the row in the "folder options" If you think the button should be moved back to just under the combo please reopen the bug report as a wish. Thanks, Kåre for the button to update the folder to be displayed, it is also necessary to change the location where the search will be made. so the location it is currently in does not solve the problem I mentioned because the same task of changing the folder location is still necessary. Actually you do not need to change the search location, but you need to click on the "show search options" button to the left of the replace input to open the folder search options... That said you need to move the mouse all the way to the left click a button and then move all the way back to the right to be able to click the "reload" button. not a good UX :( yes, they are two ways of doing the same thing. neither of them is good enough. That's why the bug should remain open, someone could look at it and try to improve. OK, I restated the summary and reopened the bug/wish. My suggested fix is to move the button back up so that we do not need to open the extended options. thanks Git commit 6b759fbc0782583b31140f74ab78e1ebb17ed505 by Kåre Särs. Committed on 20/11/2020 at 20:52. Pushed by sars into branch 'master'. S&R: Move the current-folder button to the main options Replace the find/replace labels with placeholders Move the current-folder button next to searchPlacesCombo Move the new-tab and more search-options to the right of the second row Vertical layout difference is search&replace combos on separate rows Fix tab navigation M +80 -51 addons/search/plugin_search.cpp M +1 -1 addons/search/plugin_search.h M +171 -155 addons/search/search.ui https://invent.kde.org/utilities/kate/commit/6b759fbc0782583b31140f74ab78e1ebb17ed505 |