| Summary: | Accessibility KCM crashes on Wayland due to X11-specific code | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_accessibility | Assignee: | Andrey <butirsky> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | 1i5t5.duncan, butirsky, meven.car, nate, plasma-bugs |
| Priority: | VHI | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/e3bcfc3d4fc6e27283c95b520417408940d5947a | Version Fixed In: | 5.21 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2020-11-12 17:03:07 UTC
The code in KAccesConfig is X11 specific. We need at a minimun first step hide what cannot work and not crash. Then make it work in Wayland. Hi, Gunnar Schmidt, are you working on this? I could take it. Hm, doesn't seem to crash here: just only "Screen Reader" tab is accessible on the "Accessibility" pane - other tabs are greyed out. I'm on built plasma of the same versions as in OP, Wayland session. I don't have Spectacle working in my build, but my KCM looks pretty much the same as here: https://phabricator.kde.org/D22823?id=62783 Seeing this bug here too. Wayland functionality is finally "good enough" that I've been porting my workflow and previously X-only scripts, hotkeys that don't work in wayland, etc, over. Noticed the "system bell" when (too frequently accidentally) toggling capslock/numlock was missing and a couple days layer when the more pressing porting issues were mostly done, tried to load the accessibility kcm. It crashed. So did trying to start just the individual accessibility kcm from krunner, or rather, nothing came up at all. Trying to run kcmshell5 kcm_access in konsole crashes with a segfault. straced it and the user config kaccessrc and its notifications rc were the last files touched, along with kdeglobals, but they looked fine. Still I temp-renamed them and tried again. Same segfault. Renamed them back. Quit plasma-wayland to the CLI (no *DM here) and started plasma-X. Both the caps-lock bell and the accessibility kcm worked fine. Googled accessibility wayland on bugs.kde and found this. Trying to run X-only code from a wayland app does explain things. =:^\ FWIW live-git frameworks/plasma/apps via gentoo/kde's overlay. From this bug looks like this is being worked on but I'll have to do without accidental-capslock toggling popup-notifications/bell until the fix lands. =:^( On the plus side I've got what I consider the critical workflow and config ported to wayland now and switched it to the default in my plasma startscript I think yesterday. The switch has been a pain but definitely less so than say the kde3/kde4 upgrade, by **FAR**, and about the same as the kde4/kde-plasma-5 upgrade, AND and it's mostly done, now. Kool job kdeers! =:^) It's probably this commit: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/160#note_138381 Git commit e3bcfc3d4fc6e27283c95b520417408940d5947a by Andrey Butirsky. Committed on 19/11/2020 at 07:55. Pushed by butirsky into branch 'master'. fix: Accessibility KCM crashes on Wayland It's a workaround: no X specific mouseKeysShortcut() call on Wayland M +1 -1 kcms/access/kcmaccess.cpp https://invent.kde.org/plasma/plasma-desktop/commit/e3bcfc3d4fc6e27283c95b520417408940d5947a |