| Summary: | Dead pages show up in the page sidebar | ||
|---|---|---|---|
| Product: | [Applications] plasma-systemmonitor | Reporter: | Vlad Zahorodnii <vlad.zahorodnii> |
| Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahiemstra, justin.zobel, kde, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libksysguard/commit/fea15a87388e60d719f113dbe0f2dd20a3f6b9c5 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
Confirmed on git master, blank space is left after removing two pages (my test). Can you reproduce it always? I just tried and couldn't reproduce it (In reply to David Redondo from comment #2) > Can you reproduce it always? I just tried and couldn't reproduce it I can't seem to reproduce it now but I believe I got updates (Neon Unstable) yesterday for all apps and libraries so the fix might have been in there. Vlad can you retest? Nope, still can reproduce. (I'm at 2335fb88564f33be3b875e55808ddfaf6f93bac4) A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/110 Git commit bf2d0ece6979e5bf67445981f27c456c5e85d0b4 by Arjen Hiemstra. Committed on 22/01/2021 at 13:30. Pushed by ahiemstra into branch 'master'. Prevent inadvertently writing config when destroying SensorFaceController In certain cases, we may end up with a dirty config which we do not want to store. So explicitly cleanup the config objects before destruction to prevent them from being written. M +10 -0 faces/SensorFaceController.cpp https://invent.kde.org/plasma/libksysguard/commit/bf2d0ece6979e5bf67445981f27c456c5e85d0b4 Git commit fea15a87388e60d719f113dbe0f2dd20a3f6b9c5 by Arjen Hiemstra. Committed on 25/01/2021 at 12:37. Pushed by ahiemstra into branch 'Plasma/5.21'. Prevent inadvertently writing config when destroying SensorFaceController In certain cases, we may end up with a dirty config which we do not want to store. So explicitly cleanup the config objects before destruction to prevent them from being written. (cherry picked from commit bf2d0ece6979e5bf67445981f27c456c5e85d0b4) M +10 -0 faces/SensorFaceController.cpp https://invent.kde.org/plasma/libksysguard/commit/fea15a87388e60d719f113dbe0f2dd20a3f6b9c5 |
Created attachment 133228 [details] screenshot SUMMARY STEPS TO REPRODUCE 1. Add a couple of pages 2. Remove the new pages 3. Restart Plasma System Monitor OBSERVED RESULT I see a couple of blank items in the page sidebar that most likely correspond to the removed pages EXPECTED RESULT No blank items SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: plasma-systemmonitor: bec50608b7c4ddf64ffa441425ec6684c33f385b ADDITIONAL INFORMATION Contents of systemmonitorrc after removing pages and restarting plasma system monitor ``` [General] height=914 pageOrder=overview.page,applications.page,history.page,processes.page,new_page.page,new_page1.page width=1489 ``` The config should not have "new_page.page,new_page1.page" because they were removed in the step 2.