Bug 428927

Summary: String puzzles in the user interface
Product: [Applications] kgeotag Reporter: Luigi Toscano <luigi.toscano>
Component: GeneralAssignee: Tobias Leupold <tl>
Status: RESOLVED FIXED    
Severity: normal CC: tl
Priority: NOR    
Version First Reported In: 1.0.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Luigi Toscano 2020-11-10 11:33:29 UTC 
SUMMARY

There are a few string puzzles in the current code (2933eab307b032fc40a2a0d5c7f67642d20f8195), for example (but there may be others):

https://invent.kde.org/graphics/kgeotag/-/blob/e7ba10d29af5cfa8618897a6a901c75e40f4be8c/src/MainWindow.cpp#L39
https://invent.kde.org/graphics/kgeotag/-/blob/e7ba10d29af5cfa8618897a6a901c75e40f4be8c/src/MainWindow.cpp#L4

The KI18n documentation explains why they should be avoided:
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_text
Comment 1 Tobias Leupold 2020-11-10 11:40:29 UTC 
Thanks for the hint, I'll fix this asap :-)
Comment 2 Tobias Leupold 2020-11-10 20:21:30 UTC 
Git commit c67988a701f062deb0a82b701881b5873b6da56d by Tobias Leupold.
Committed on 10/11/2020 at 20:20.
Pushed by tleupold into branch 'master'.

Better translatability for MainWindow::addGpx

M  +81   -42   src/MainWindow.cpp

https://invent.kde.org/graphics/kgeotag/commit/c67988a701f062deb0a82b701881b5873b6da56d
Comment 3 Tobias Leupold 2020-11-10 22:10:31 UTC 
Git commit cdd8d413e82a067b93ea9e1715d0fd82880ef056 by Tobias Leupold.
Committed on 10/11/2020 at 22:10.
Pushed by tleupold into branch 'master'.

Better translatability for MainWindow::addImages

M  +87   -54   src/MainWindow.cpp

https://invent.kde.org/graphics/kgeotag/commit/cdd8d413e82a067b93ea9e1715d0fd82880ef056
Comment 4 Tobias Leupold 2020-11-11 08:33:00 UTC 
Git commit 9ab424c25fabeb4931e2bd5335e7c857bcf06594 by Tobias Leupold.
Committed on 11/11/2020 at 08:31.
Pushed by tleupold into branch 'master'.

Better translatability for MainWindow::matchAutomatically

M  +31   -24   src/MainWindow.cpp

https://invent.kde.org/graphics/kgeotag/commit/9ab424c25fabeb4931e2bd5335e7c857bcf06594
Comment 5 Tobias Leupold 2020-11-11 14:18:55 UTC 
Git commit a252651e12770198824338bc7da9c65ee57c0cd4 by Tobias Leupold.
Committed on 11/11/2020 at 14:18.
Pushed by tleupold into branch 'master'.

Better translatability for MainWindow::saveChanges

M  +64   -62   src/MainWindow.cpp
M  +2    -0    src/MainWindow.h

https://invent.kde.org/graphics/kgeotag/commit/a252651e12770198824338bc7da9c65ee57c0cd4
Comment 6 Tobias Leupold 2020-11-11 14:21:06 UTC 
I hope I could reformat the messages in question so that the translatability is given now. Feel free to complain here if not ;-)
Comment 7 Tobias Leupold 2021-01-08 16:20:14 UTC 
As no translator complained anymore, I'll close this now. Feel free to re-open if there are still issues like this one!