Bug 428774

Summary: Embedding artists and albums messes up the selection afterwards
Product: [Applications] Elisa Reporter: ivan.planinar
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED DUPLICATE    
Severity: normal CC: justin.zobel, nate, postix
Priority: NOR    
Version: 20.08.3   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Image showing this
Messed up menus
attachment-27131-0.html

Description ivan.planinar 2020-11-07 01:32:08 UTC
Created attachment 133098 [details]
Image showing this

SUMMARY
After embedding albums then artists, the selection of anyone in the list is not accurate anymore.

STEPS TO REPRODUCE
1. Embed Artist
2. Embed Albums
3. Notice after scrolling down and picking albums, they are not the one you selected.

OBSERVED RESULT
Say you have Billy idol and Bauhaus in the list, among many many others. You select Bauhaus but Billy Idol Album appears. It gets worse the more you scroll in the list. There's some kind of total mismatch of selected vs. actual results.

EXPECTED RESULT
Matched artists/albums to the songs.

Arch linux, latest KDE and Elisa.
Comment 1 ivan.planinar 2020-11-07 01:35:57 UTC
Oh yeah, also notice what happens when Embedding is turned off.

The menus are now messed up. While showing like "artists" are "radios".
Comment 2 ivan.planinar 2020-11-07 01:36:16 UTC
Created attachment 133099 [details]
Messed up menus
Comment 3 Justin Zobel 2020-11-07 02:10:55 UTC
Ivan can you please elaborate further on the steps to reproduce, what do you mean by embed?
Comment 4 ivan.planinar 2020-11-07 09:26:56 UTC
(In reply to Justin Zobel from comment #3)
> Ivan can you please elaborate further on the steps to reproduce, what do you
> mean by embed?

In Configure -> General, there's a drop down menu:

Embed a category in the views navigation list: No embedded data. I can select "Embed Albums / Artists / Genres."

Steps to reproduce:

1. Select - Embed Albums in Configure Elisa.

2. Albums will be embedded in the left menu.

3. Scroll down a bit in that list

4. Choose an album - different one will be shown. Notice it is not the same album you pick. I attached a screenshot of that above.

I hope it's more clear now.
Comment 5 Justin Zobel 2020-11-08 00:25:09 UTC
Thanks Ivan, I can confirm in Elisa from git master, it is not selecting the correct Album.
Comment 6 ivan.planinar 2020-11-08 09:03:58 UTC
(In reply to Justin Zobel from comment #5)
> Thanks Ivan, I can confirm in Elisa from git master, it is not selecting the
> correct Album.

It's both Album and Artists. Issue is the same.

May I also suggest one thing that is separate from this bug - it would be nice if double click on a track would make it PLAY. 

Currently, default is to add it to the playlist. But it's more logical to play that track. That behaviour is built into all other music players too.

Thanks.
Comment 7 Justin Zobel 2020-11-08 09:31:15 UTC
Created attachment 133134 [details]
attachment-27131-0.html

If you can please place the play on double click into its own bug report
and set priority to wishlist that way it won't get lost with the bug
reports.

On Sun, Nov 8, 2020 at 7:34 PM <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=428774
>
> --- Comment #6 from ivan.planinar@gmail.com ---
> (In reply to Justin Zobel from comment #5)
> > Thanks Ivan, I can confirm in Elisa from git master, it is not selecting
> the
> > correct Album.
>
> It's both Album and Artists. Issue is the same.
>
> May I also suggest one thing that is separate from this bug - it would be
> nice
> if double click on a track would make it PLAY.
>
> Currently, default is to add it to the playlist. But it's more logical to
> play
> that track. That behaviour is built into all other music players too.
>
> Thanks.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 8 Nate Graham 2022-04-18 21:34:04 UTC
Same root cause as Bug 436424.

*** This bug has been marked as a duplicate of bug 436424 ***