Summary: | On KDE CI alkonlinequotetest fails while parsing the date | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libalkimia | Reporter: | Ralf Habacker <ralf.habacker> |
Component: | General | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 8.0.4 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/office/alkimia/commit/1534aa745a76565b979f6e0b60ef5920055e98a9 | Version Fixed In: | 8.0.5 |
Description
Ralf Habacker
2020-11-04 11:29:49 UTC
In the associated test, the service https://fx-rate.net/BTC/GBP is used. Once with a simple https request via KIO and the second time with a real browser instance (Webkit), whereby the website returns different date formats. In the first case it is a complete date, in the second case only the time. Since the rule expects a complete date, the error message is returned. A fix would be to change the q ... A fix could be to set the attribute for the date and/or the date format of the citation source to an empty value and in this case check the error return of AlkOnlineQuote::launch() to see if the returned error concerns the date and then ignore the error. A possibly relevant merge request was started @ https://invent.kde.org/office/alkimia/-/merge_requests/4 Git commit 42296b9ce8ff38a523526e4042bec6821279aaa5 by Ralf Habacker. Committed on 04/11/2020 at 12:41. Pushed by habacker into branch '8.0'. Add support for skipping date extraction when a quote service does not provide a valid date The state of date parsing is also reflected into the associated ui. FIXED-IN:8.0.5 M +6 -2 src/alkonlinequote.cpp M +3 -0 src/alkonlinequote.h M +10 -2 src/alkonlinequotesprofile.cpp M +8 -3 src/alkonlinequoteswidget.cpp https://invent.kde.org/office/alkimia/commit/42296b9ce8ff38a523526e4042bec6821279aaa5 Git commit 1534aa745a76565b979f6e0b60ef5920055e98a9 by Ralf Habacker. Committed on 05/11/2020 at 08:44. Pushed by habacker into branch 'gitlab-ci-test'. Added support for skipping date extraction when a quote service does not provide a valid date FIXED-IN:8.0.5 M +9 -0 src/alkonlinequotesource.cpp https://invent.kde.org/office/alkimia/commit/1534aa745a76565b979f6e0b60ef5920055e98a9 Git commit 4209011cba698943b623d890b7d5d76ebee31ff6 by Ralf Habacker. Committed on 22/11/2020 at 21:54. Pushed by habacker into branch '8.0'. Added documentation to method AlkOnlineQuoteSource::setDate() M +9 -0 src/alkonlinequotesource.cpp https://invent.kde.org/office/alkimia/commit/4209011cba698943b623d890b7d5d76ebee31ff6 |