Bug 428605

Summary:	Transform tool preview and over view docker are not colour managed.
Product:	[Applications] krita	Reporter:	Raghavendra kamath <raghu>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	dimula73, tamtamy.tymona
Priority:	NOR
Version:	4.4.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Raghavendra kamath 2020-11-02 14:50:01 UTC

SUMMARY
When user initiates transform tool the resulting preview enclosed within the transform handles is not colour managed. This sometimes becomes distracting. In addition to this the overview docker is also not colour aware.

STEPS TO REPRODUCE
1. Open a new document in Krita and make sure that you are using your monitor profile in the display setting.
2. Choose #008a3e as your foreground colour.
3. Draw a big patch on the canvas with this colour.
4. Select a portion of this patch and then press Ctrl T to enable transform tool.
5. You might notice that the colours are different for this selected patch. In addition the over view docker also shows wrong colour always.

OBSERVED RESULT
Colour management is ignored when transform tool is active
Colour management is ignored in the overview docker

EXPECTED RESULT
Everything should be colour aware inside Krita.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.20.2
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Kernel Version: 5.9.2-arch1-1
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 31.3 GiB of RAM
Graphics Processor: GeForce GTX 750 Ti/PCIe/SSE2

Comment 1 Tiar 2020-11-18 15:23:36 UTC

This is a bit tricky because all of those components are drawn using Qt's QPainter. See bug 406698. I guess they might need some additional converting.

Comment 2 Dmitry Kazakov 2021-05-21 11:21:53 UTC

Git commit 4a9fa390a1155202e16d0c6656dd3ff3c8088010 by Dmitry Kazakov.
Committed on 21/05/2021 at 11:21.
Pushed by dkazakov into branch 'master'.

Fix display color management in Overview docker

M  +15   -4    plugins/dockers/overview/OverviewThumbnailStrokeStrategy.cpp
M  +14   -1    plugins/dockers/overview/OverviewThumbnailStrokeStrategy.h
M  +10   -2    plugins/dockers/overview/overviewwidget.cc

https://invent.kde.org/graphics/krita/commit/4a9fa390a1155202e16d0c6656dd3ff3c8088010

Comment 3 Dmitry Kazakov 2021-05-21 11:22:38 UTC

The color management for the transform tool is not very actual now, since we have in-stack preview.

*** This bug has been marked as a duplicate of bug 406698 ***

Comment 4 Dmitry Kazakov 2021-06-01 13:15:29 UTC

Git commit 88a744d9f6e33a843aa65904dac34b5936e9a777 by Dmitry Kazakov.
Committed on 01/06/2021 at 12:08.
Pushed by dkazakov into branch 'krita/4.3'.

Fix display color management in Overview docker

M  +15   -4    plugins/dockers/overview/OverviewThumbnailStrokeStrategy.cpp
M  +14   -1    plugins/dockers/overview/OverviewThumbnailStrokeStrategy.h
M  +10   -2    plugins/dockers/overview/overviewwidget.cc

https://invent.kde.org/graphics/krita/commit/88a744d9f6e33a843aa65904dac34b5936e9a777