Bug 428438

Summary: Installer creates sambashare with gid 1000
Product: [KDE Neon] neon Reporter: Mario Splivalo <mario+bugs.kde.org>
Component: Live/Install imagesAssignee: Neon Bugs <neon-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: jr, nate, neon-bugs-null, sitter
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/neon/neon/calamares-settings/commit/05c7a8912417553d064f715e90880f86ed3b9be3 Version Fixed/Implemented In:
Sentry Crash Report:

Description Mario Splivalo 2020-10-29 15:55:38 UTC 
SUMMARY

User related gids and uids start at 1000. With KDE Neon 20.04 this is not the case, the user created trough installer has gid 1001.

This is not in-line with all other distros, where 1st created user has uid/gid of 1000/1000. Even previous versions of Neon (16.04, 18.04) followed this rule.

For some reason sambashare group has gid 1000, although on liveCD it has gid 131. On my Neon 18.04 sambashare had gid 121.


STEPS TO REPRODUCE
1. Download lates Neon iso
2. Install it in KVM/Virtualbox
3. Log in as user, type 'id'

OBSERVED RESULT
marios@neonka:~$ id
uid=1000(marios) gid=1001(marios) groups=1001(marios),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),1000(sambashare)


EXPECTED RESULT
marios@neonka:~$ id
uid=1000(marios) gid=1000(marios) groups=1001(marios),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),131(sambashare)




This is not a problem so much, merely an annoyance. I reinstalled my system and all of my NFS shares are now broken because of wrong UIDs :) 

I think that installer, when creating sambashare group, for some reason uses the wrong gid, but I haven't been able to pinpoint it.

Regards, 

Mario
Comment 1 Nate Graham 2020-10-29 19:30:10 UTC 
Neon uses the Calamares installer; please report there: https://github.com/calamares/calamares/issues
Comment 2 Harald Sitter 2020-11-04 14:50:07 UTC 
Git commit 05c7a8912417553d064f715e90880f86ed3b9be3 by Harald Sitter.
Committed on 04/11/2020 at 14:49.
Pushed by sitter into branch 'Neon/stable'.

use new users annotations

this allows us to add the sambashare group as system user. furthermore
tag all other groups as must_exist so installation fails should they not
be available in the future as that'll need inspection by a human for
renamed variants or if their disappearance is even called for

these annotations will only be available when the next calamares release
comes out

M  +7    -0    desktop/calamares/desktop/modules/users.conf

https://invent.kde.org/neon/neon/calamares-settings/commit/05c7a8912417553d064f715e90880f86ed3b9be3
Comment 3 Mario Splivalo 2020-11-22 20:24:27 UTC 
I just downloaded latest Neon install iso: neon-user-20201119-0945.iso

The issue is still present there. When system is installed, after I log in, my user has gid 1001 and sambashare has gid of 1000.

Is this supposed to be fixed in the latest version available for download?
Comment 4 Harald Sitter 2020-11-23 10:52:23 UTC 
No. Releases need to bubble through QA and that can take a while.
Comment 5 Mario Splivalo 2020-11-23 11:50:53 UTC 
Thnx, Harald. Is there a place I can see the progress/process for QAing this change, and all of that?

Mario
Comment 6 Harald Sitter 2020-11-23 12:08:16 UTC 
There's various bits that factor into this. For the most part things never land in user edition unless this job ran and is green https://build.neon.kde.org/view/management/job/mgmt_snapshot_focal_user/ which it now is so the next ISO build should contain the new calamares.
Comment 7 Mario Splivalo 2020-11-29 19:30:32 UTC 
This is, indeed, fixed now.

I'm just a bit confused that sambashare has guid of 999 now, not 131 (or whatever it was) with previous version of Neon.

mario@neja:~$ id
uid=1000(mario) gid=1000(mario) groups=1000(mario),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),999(sambashare)

Thank you :)

Mario