Bug 428388

Summary:	Add `image-missing` icon
Product:	[Plasma] Breeze	Reporter:	infowgn
Component:	Icons	Assignee:	visual-design
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	kainz.a, nate, personalizedrefrigerator
Priority:	NOR
Version:	5.18.4
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/breeze-icons/408fe187d38ffa6d2883046c30a404062524e2a9	Version Fixed In:	5.78
Sentry Crash Report:

Description infowgn 2020-10-28 12:52:47 UTC

SUMMARY


STEPS TO REPRODUCE
1. Start xournal++
2. Press SAVE-button
3. Change directory 

OBSERVED RESULT
xournal++ chrashes while changing directory in file sve dialog




SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 20.04 / Plasma 5.18.4 shipped with Kubuntu 20.04
KDE Plasma Version: 5.18.4
KDE Frameworks Version: ???
Qt Version: 5

ADDITIONAL INFORMATION
Output of xournalpp: 
Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Icon 'image-missing' not present in theme breeze (gtk-icon-theme-error-quark, 0)
Bail out! Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Icon 'image-missing' not present in theme breeze (gtk-icon-theme-error-quark, 0)

If I use another icon set than breeze, xournal++ works perfectly.

The guys of xournal++ say it's not a problem of xournal++ but it's a problem of the icon set. (https://github.com/xournalpp/xournalpp/issues/999)

Any ideas to use xournal++ with the breeze icons? I love the breeze icon set.

Comment 1 Nate Graham 2020-10-28 16:05:47 UTC

We can add an `image-missing` icon. However it's undoubtedly a bug in the app or in GTK that it crashes when this icon is missing. At worst, it should display nothing. Missing icons should never crash an app, that's just crazy!

Comment 2 Christoph Feck 2020-11-23 12:16:21 UTC

As a workaround, you can copy/symlink an existing icon image file to the expected filename of the missing icon file.

Comment 3 infowgn 2020-11-23 14:35:37 UTC

Thanks, I tried this before I wrote my first post without success. Perhaps I linked at the wrong location.

The oxygen icon set works for me. The command "locate image-missing | grep oxygen" shows:

/usr/share/icons/oxygen/base/128x128/status/image-missing.png
/usr/share/icons/oxygen/base/16x16/status/image-missing.png
/usr/share/icons/oxygen/base/22x22/status/image-missing.png
/usr/share/icons/oxygen/base/32x32/status/image-missing.png
/usr/share/icons/oxygen/base/48x48/status/image-missing.png
/usr/share/icons/oxygen/base/64x64/status/image-missing.png

So I tried to place in all  corresponding dirs of "/usr/share/icons/breeze" a link to the files in the oxygen icon set, but in "/usr/share/icons/breeze" there is no dir "base". 
Following I copied the whole dir "/usr/share/icons/oxygen/base/" to "/usr/share/icons/breeze/", but xournalpp crashes with the same error message:

Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Icon 'image-missing' not present in theme breeze (gtk-icon-theme-error-quark, 0)

At which location I have to store the "images-missing" icons?

Comment 4 Christoph Feck 2020-12-11 17:14:23 UTC

I don't know how GTK or xournal search icons. If everything else fails, search the image-missing name in the strace output.

Comment 5 personalizedrefrigerator 2020-12-19 21:22:12 UTC

This should have been fixed by https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/67 !

Comment 6 Nate Graham 2020-12-19 21:56:56 UTC

Yep!