| Summary: | Avatar within RoundButton doesn't consistently handle touch events | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | Janet Blackquill <uhhadd> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, mikel5764, nate, nicolas.fella, notmart, plasma-bugs-null, uhhadd |
| Priority: | NOR | ||
| Version First Reported In: | 5.22.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | 6.0 | |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2020-10-28 10:10:08 UTC
Confirmed even with the new kickoff. odd, it's just a regular RoundButton it might be an issue with the component itself. Nate can you investigate? Yeah the problem is the avatar's own click handling overriding that of the button. Browsing the Avatar component's code, it looks like the intention is to have its mouse area only enabled then the Avatar item has actions attached to it, but this doesn't seem to be working as it should, because the mouse area is always eating clicks anyway. Jan, can you investigate further? Thanks! Git commit 6a8bf09cfd54abe6dc5789f7cf713e4fec362606 by Nate Graham, on behalf of Jan Blackquill. Committed on 25/01/2021 at 22:02. Pushed by ngraham into branch 'master'. kickoff: use Kirigami.Avatar directly instead of wrapping in RoundButton This works around a Kirigami bug in a manner that can be shipped in 5.21, as well as bringing consistency with other clickable avatars which typically use actions.main instead of wrapping the Avatar in another component. As a bonus, we lose a lot of excess code. M +6 -18 applets/kickoff/package/contents/ui/Header.qml https://invent.kde.org/plasma/plasma-desktop/commit/6a8bf09cfd54abe6dc5789f7cf713e4fec362606 Git commit a74b1119fc6cd2308784f3dc864db4f30a878cec by Nate Graham, on behalf of Jan Blackquill. Committed on 25/01/2021 at 22:03. Pushed by ngraham into branch 'Plasma/5.21'. kickoff: use Kirigami.Avatar directly instead of wrapping in RoundButton This works around a Kirigami bug in a manner that can be shipped in 5.21, as well as bringing consistency with other clickable avatars which typically use actions.main instead of wrapping the Avatar in another component. As a bonus, we lose a lot of excess code. (cherry picked from commit 6a8bf09cfd54abe6dc5789f7cf713e4fec362606) M +6 -18 applets/kickoff/package/contents/ui/Header.qml https://invent.kde.org/plasma/plasma-desktop/commit/a74b1119fc6cd2308784f3dc864db4f30a878cec (In reply to Nate Graham from comment #5) > Git commit a74b1119fc6cd2308784f3dc864db4f30a878cec by Nate Graham, on > behalf of Jan Blackquill. > Committed on 25/01/2021 at 22:03. > Pushed by ngraham into branch 'Plasma/5.21'. > > kickoff: use Kirigami.Avatar directly instead of wrapping in RoundButton > > This works around a Kirigami bug in a manner that can be shipped in 5.21, as > well as > bringing consistency with other clickable avatars which typically use > actions.main > instead of wrapping the Avatar in another component. > > As a bonus, we lose a lot of excess code. > > > (cherry picked from commit 6a8bf09cfd54abe6dc5789f7cf713e4fec362606) > > M +6 -18 applets/kickoff/package/contents/ui/Header.qml > > https://invent.kde.org/plasma/plasma-desktop/commit/ > a74b1119fc6cd2308784f3dc864db4f30a878cec are those 2 commits confirmed to fix is? can be closed now? Fixed for me now. Can reproduce again on neon unstable. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.23.80 KDE Frameworks Version: 5.88.0 Qt Version: 5.15.3 Graphics Platform: X11 It got put inside a RoundButton again, which broke it again. We need to either stop doing that, or make this use case work since clearly there is a desire to do to. Did some investigation and the mousearea in the avatar isn't the primary problem here. The problem seems to be that our RoundButton with an avatar inside it isn't consistently handling touch events. It does *sometimes* but not all the time. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/393 Nope, RoundButton itself is fine here as this works when I remove the Avatar from it. Somehow making making its contentItem be a Kirigami.Avatar breaks touch. Aha, it's not the tree indicators being wrong at all - it's a space reserved for an icon where applicable. This has been fixed with the Plasma 6 Avatar refactoring. |