Bug 428276

Summary:	KContacts cannot be used in qmake project
Product:	[Frameworks and Libraries] frameworks-kcontacts	Reporter:	Adam Pigg <adam>
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kcontacts/commit/9f4508d3f73527bf93b213d164cb28a27c75dcf4	Version Fixed/Implemented In:
Sentry Crash Report:

Description Adam Pigg 2020-10-26 15:06:42 UTC

SUMMARY
When including KContacts in a qmake project, it tried to pull in the module CoreAddons and not KCoreAddons.

STEPS TO REPRODUCE
1. In a qmake project, add QT += KContacts
2. Run qmake
3. See error due to non existent CoreAddons library

OBSERVED RESULT


EXPECTED RESULT
qmake finishes successfully.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Error is on thie line https://invent.kde.org/frameworks/kcontacts/-/blob/master/src/CMakeLists.txt#L147

IRC Discussion:
[14:48] <piggz> hi, im wondering if this is an error in KContacts library.....
[14:48] <piggz> cat /usr/lib64/qt5/mkspecs/modules/qt_KCoreAddons.pri 
[14:48] <piggz> QT.KContacts.depends = CoreAddons
[14:49] <piggz> Should that CoreAddons actually be KCoreAddons ?
[14:49] <piggz> cat /usr/lib64/qt5/mkspecs/modules/qt_KCoreAddons.pri 
[14:49] <piggz> QT.KCoreAddons.module = KF5CoreAddons
[14:49] <piggz> or maybe kf5coreaddons
[14:49] <piggz> in any case, if i include kcontacts in a qt project, it fails qmake due to missing coreaddons
[14:52] <nicofee> piggz: according to https://api.kde.org/frameworks/kcoreaddons/html/index.html KCoreAddons is correct
[14:53] <piggz> nicofee: so, its a bug in the kconacts .pri .... i guess noone tried such a thing before? :D
[14:53] <krop> we're not crazy enough to use qmake unless forced to
[14:53] <krop> :)
[14:53] <nicofee> yeah, probably no one ever tried
[14:54] <piggz> according to https://api.kde.org/frameworks/kcoreaddons/html/index.html .....
[14:54] <nicofee> piggz: https://invent.kde.org/frameworks/kcontacts/-/blob/master/src/CMakeLists.txt#L147
[14:54] <piggz> Use with QMake
[14:54] <piggz>     QT += KCoreAddons 
[14:54] <piggz> ;)
[14:55] <nicofee> Probably only needs s/CoreAddons/KCoreAddons/ in that call
[15:00] <piggz> yeah

Comment 1 Laurent Montel 2020-10-26 16:15:19 UTC

Git commit 9f4508d3f73527bf93b213d164cb28a27c75dcf4 by Laurent Montel.
Committed on 26/10/2020 at 16:14.
Pushed by mlaurent into branch 'master'.

Fix Bug 428276 - KContacts cannot be used in qmake project

M  +1    -1    src/CMakeLists.txt

https://invent.kde.org/frameworks/kcontacts/commit/9f4508d3f73527bf93b213d164cb28a27c75dcf4