Bug 428249

Summary:	previous brush shortcut no longer works
Product:	[Applications] krita	Reporter:	Toby <tobywillsmer>
Component:	Shortcuts and Canvas Input Settings	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	major	CC:	ahab.greybeard, lynx.mw+kde
Priority:	NOR
Version First Reported In:	4.4.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	attachment-29228-0.html

Description Toby 2020-10-26 00:09:38 UTC

SUMMARY
the previous brush shortcut no longer works once you start to paint, it only works when you are changing brushes in the docker.

I have the previous brush shortcut set to a custom key, the return key.

This works as normal in all versions under krita-4.3.0-x86_64.appimage but not in the latest version 4.4.0

STEPS TO REPRODUCE
1. Open a new file
2. select a brush in the docker
3. then select a different brush in the docker
4. keep the cursor in the docker area and before painting anything use the previous brush shortcut
5. This works as expected
6. now paint something on the canvas
7. then try the previous brush shortcut again
8. the shortcut does not work whilst the canvas is actively being painted on

OBSERVED RESULT
The previous brush shortcut only works if you select brushes in the brushes docker. Once painting, it no longer works unless you switch brushes again in the docker.

EXPECTED RESULT
The previous brush shortcut should switch between the latest brush and the previous one whilst painting


SOFTWARE/OS VERSIONS

Linux/KDE Plasma: Ubuntu 18.0.4
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Lynx3d 2020-10-26 02:12:20 UTC

While I can confirm this when setting "Switch to Previous Preset" to "Return", this is somewhat expected, because by default "Return" is already bound to "Confirm" in Canvas Input Settings => Tool Invocation.

I'm not sure why it worked before, it may be a change introduced by fixing bug 409613, but I'm inclined to say that it never should have worked in the first place, because that means one key press potentially triggers two unrelated actions.

Resolve the key binding conflict, and it should work as expected, at least it does for me.

Comment 2 Toby 2020-10-26 22:11:16 UTC

(In reply to Lynx3d from comment #1)
> While I can confirm this when setting "Switch to Previous Preset" to
> "Return", this is somewhat expected, because by default "Return" is already
> bound to "Confirm" in Canvas Input Settings => Tool Invocation.
> 
> I'm not sure why it worked before, it may be a change introduced by fixing
> bug 409613, but I'm inclined to say that it never should have worked in the
> first place, because that means one key press potentially triggers two
> unrelated actions.
> 
> Resolve the key binding conflict, and it should work as expected, at least
> it does for me.

Ah yep, changed it and it's ok.

Comment 3 Ahab Greybeard 2020-10-28 17:35:59 UTC

So, should this be Resolved, Not a Bug?

Comment 4 Toby 2020-10-29 02:34:01 UTC

Created attachment 132850 [details]
attachment-29228-0.html

Yep it can be resolved now as not a bug unless you have conflicting custom
shortcuts


Kind regards
Toby Willsmer | Illustrator
Based in Wellington, New Zealand
[image: Logo] <http://www.willsmer.com>
e:tobywillsmer@gmail.com
w:willsmer.com <http://www.willsmer.com>
s:instagram/tobywillsmer <https://www.instagram.com/tobywillsmer>



On Thu, 29 Oct 2020 at 06:36, Ahab Greybeard <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=428249
>
> Ahab Greybeard <ahab.greybeard@hotmail.co.uk> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|
> |ahab.greybeard@hotmail.co.u
>                    |                            |k
>
> --- Comment #3 from Ahab Greybeard <ahab.greybeard@hotmail.co.uk> ---
> So, should this be Resolved, Not a Bug?
>
> --
> You are receiving this mail because:
> You reported the bug.