Summary: | Not able to render PSD file with depth other than 8 and 16 | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kimageformats | Reporter: | Gary Wang <wzc782970009> |
Component: | general | Assignee: | Alex Merry <alex.merry> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles, kdelibs-bugs, mircomir |
Priority: | NOR | ||
Version: | 5.75.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | All | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Example PSD file with depth == 16 |
Description
Gary Wang
2020-10-25 16:55:05 UTC
Created attachment 132735 [details]
Example PSD file with depth == 16
Inside the zip file, there is an example PSD file with depth == 16 and image data doesn't have compression.
Probably fixed by https://invent.kde.org/frameworks/kimageformats/-/merge_requests/5 (In reply to Christoph Feck from comment #2) > Probably fixed by > https://invent.kde.org/frameworks/kimageformats/-/merge_requests/5 !4 and !5 partially fixed this issue for 16-bits PSD files, there are still 32-bits and 1-bit not supported from kimageformats (but krita do support them btw). Then !5 is probably wrong. It seems to assume that the only possible depth values are 8 and 16. (In reply to Christoph Feck from comment #4) > Then !5 is probably wrong. It seems to assume that the only possible depth > values are 8 and 16. The old implementation only supports 8-bits pre channel. Both !4 (by me) and !5 (by @chrisx) are intended to only add 16-bits support to the current PSD reader. Adding 1-bit and 32-bits will also need extra work to do, consider this as a feature request :) There are CMYK and other color mode not supported by kimageformats' PSD reader, but I think (A)RGB/8 and (A)RGB/16 would cover most of the use case for casual user who need to view PSD files got from friends or from the Internet ;P Btw I still hope guys from Krita dev team can also take a look but I'm not sure if I'm barking up the wrong tree, Krita's PSD support is much more complete than kimageformats', but I'm not sure if it's possible to port Krita's PSD support to this project and let Krita make use of this project directly if needed. This should be solved by MR !56 (https://invent.kde.org/frameworks/kimageformats/-/merge_requests/56) Hi, Look the story here : https://bugs.kde.org/show_bug.cgi?id=261088 PSD >= 16 bits encoded as integer or float data is now supported since KF5 5.95. Best Gilles Caulier Yeah, you're right, sorry I forgot to mark it as fixed when I noticed it's fixed. Thanks for the patch and release! |