Bug 427913

Summary: Resizing the sidebar causes disk write to go up
Product: [Applications] okular Reporter: Singcoi Lau <hollowwings13>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal CC: geisserml, luigi.toscano, nate, popov895, tinozzo123
Priority: NOR    
Version: 22.12.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=441676
https://bugs.kde.org/show_bug.cgi?id=389411
https://bugs.kde.org/show_bug.cgi?id=430190
Latest Commit: Version Fixed In: 23.03

Description Singcoi Lau 2020-10-18 09:32:14 UTC
jbd2 uses an excessive amount of disk resources when resizing the sidebar.
This is especially annoying on systems with HDDs, such as mine.

iotop sample:
    Total DISK READ :   0.00 B/s | Total DISK WRITE :    103.08  K/s
    Actual DISK READ:   0.00 B/s | Actual DISK WRITE:    1104.06 K/s

    TID   PRIO USER     DISK READ  DISK WRITE SWAPIN   IO    COMMAND
    1095  be/3 root     0.00 B/s    0.00 B/s  0.00 % 81.14 % [jbd2/sda7-8]
    13819 be/4 root     0.00 B/s    0.00 B/s  0.00 %  0.43 % [kworker/5:0-events]
    13266 be/4 slau     0.00 B/s  103.62 K/s  0.00 %  0.25 % okular

I/O goes back to zero when I release the click.

STEPS TO REPRODUCE
1. Open Ocular
2. Click on the sidebar and drag it side-to-side (with or without a document opened)

OBSERVED RESULT
brrrrrrrrrrrr


SOFTWARE/OS VERSIONS
OS: openSUSE Tumbleweed
KDE Plasma Version: 5.20.0
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Kernel Version: 5.8.14
Display Server: X11
Comment 1 Nate Graham 2020-10-21 03:58:52 UTC
It's updating the config file's saved data for the sidebar width. We should only do this on mouse release, not on any movement.
Comment 2 Laura David Hurka 2021-10-16 20:00:21 UTC
I think this may be the cause for some other bug reports. Adding them to See Also.
Comment 3 geisserml 2023-01-14 19:17:40 UTC
I reported Bug 441676 linked in the See Also section, and unfortunately the problem still persists with Okular 22.12.1.
Comment 4 geisserml 2023-01-14 19:19:50 UTC
*** Bug 441676 has been marked as a duplicate of this bug. ***
Comment 5 Luigi Toscano 2023-01-14 23:22:37 UTC
(In reply to geisserml from comment #3)
> I reported Bug 441676 linked in the See Also section, and unfortunately the
> problem still persists with Okular 22.12.1.

Please don't change the Version field, which represents the _initial_ version which showed the issue. Unfortunately it's not possible to readd the previous value because it's tool old. For the record, it was 1.11.2.
Comment 6 geisserml 2023-01-15 15:18:43 UTC
> Please don't change the Version field, which represents the _initial_ version which showed the issue.
Ah, that makes sense. Sorry!
Comment 7 popov895 2023-01-15 18:57:37 UTC
Isn't this fixed along with BUG 455013?
Comment 8 geisserml 2023-01-15 20:00:31 UTC
(In reply to popov895 from comment #7)
> Isn't this fixed along with BUG 455013?
Certainly looks like a nice change, but I can't tell if it will actually fix this issue (AFAICS, the topic resizing wasn't explicitly mentioned anywhere on that MR). If I'm not mistaken, the change is supposed to land in Okular 23.04?
Comment 9 popov895 2023-01-16 08:28:01 UTC
Yes, but you can already use an KDE neon Developer Edition to test it.
Comment 10 geisserml 2023-01-16 14:37:27 UTC
@popov895 Ah, I just realized by name that you are probably the author of the MR yourself? If that's right, then thanks a lot for your work!

I just installed the okular beta via kdeapps flatpak and can confirm that the bug is indeed fixed.
Resizing is now super smooth again, as it used to be back in 2020. And of course it's nice the panel can now be moved.