Summary: | lmw, lswi and related PowerPC insns aren't allowed on ppc64le | ||
---|---|---|---|
Product: | [Developer tools] valgrind | Reporter: | Mark Wielaard <mark> |
Component: | general | Assignee: | Julian Seward <jseward> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cel, will_schmidt |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Don't compile ppc64be tests on ppc64le |
Description
Mark Wielaard
2020-10-17 15:16:28 UTC
Created attachment 132536 [details]
Don't compile ppc64be tests on ppc64le
There is a similar issue with the ldst_multiple testcase.
This patch works around it by not building (or running) both tests unless on ppc64be.
The change looks reasonable to me. +# lsw compiles (and runs) only on big endian. +if VGCONF_PLATFORMS_INCLUDE_PPC64BE_LINUX +check_PROGRAMS += lsw ldst_multiple +endif The comment there could be updated since this change includes more than just lsw, but thats not a big deal. Thanks! commit 74b74174d572fee4015b8f4e326db3cd949bcdc3 Author: Mark Wielaard <mark@klomp.org> Date: Tue Dec 1 14:57:39 2020 +0100 lmw, lswi and related PowerPC insns aren't allowed on ppc64le Newer binutils produce an error when the assembly contains lmw, stmw, lswi, lswx, stswi, or stswx instructions in little-endian mode. Only build and run the lsw and ldst_multiple testcases on ppc64[be]. https://bugs.kde.org/show_bug.cgi?id=427870 |