Bug 427863

Summary:	Dragging a folder onto albums tree view sidebar will import with name of parent folder
Product:	[Applications] digikam	Reporter:	Jens <jens-bugs.kde.org>
Component:	Albums-TreeView	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metzpinguin
Priority:	NOR
Version:	7.0.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/d7b9b9c7c5d7e77525914b21cd795a204a76ba9d	Version Fixed In:	7.2.0
Sentry Crash Report:

Description Jens 2020-10-17 13:03:23 UTC

SUMMARY
see $SUBJECT

STEPS TO REPRODUCE
1. drag e.g. ~/tmp/000_images_tmp/Christmas_2014 onto a folder in Digikams left albums sidebar. Christmas_2014 should contain some images.

OBSERVED RESULT
The resulting folder in Digikam will be named 000_images_tmp, not Christmas_2014.

EXPECTED RESULT
If a single folder is dragged, use the name of that folder as a folder, just if the drag was into a file manager.
If several files or folders are dragged, use the name of the parent folder. Or ask for a folder name, providing the parent folder as a default choice (but you can also rename later).


SOFTWARE/OS VERSIONS
Linux KDE Neon 20.04 with all current updates, Digikam appimage 7.0.0 release

Comment 1 Maik Qualmann 2020-10-17 15:28:45 UTC

I cannot reproduce the problem here with digiKam-7.2.0-Beta1. From which program do you drag the folder? With Dolphin?

Maik

Comment 2 Jens 2020-10-17 20:27:37 UTC

7.2.0 appimage downloaded today.
You have to drag onto a folder in the left "albums" sidebar, and you have to select "move" in the popup menu.

Comment 3 Maik Qualmann 2020-10-17 21:29:13 UTC

Git commit d7b9b9c7c5d7e77525914b21cd795a204a76ba9d by Maik Qualmann.
Committed on 17/10/2020 at 21:28.
Pushed by mqualmann into branch 'master'.

fix move folder to the wrong destination name
FIXED-IN: 7.2.0

M  +2    -1    NEWS
M  +1    -1    core/libs/iojobs/iojob.cpp

https://invent.kde.org/graphics/digikam/commit/d7b9b9c7c5d7e77525914b21cd795a204a76ba9d

Comment 4 Maik Qualmann 2020-10-17 21:31:52 UTC

The problem depended on whether the folder to be moved was on the same partition as the collection. Everything was fine on different partitions.

Maik

Comment 5 Maik Qualmann 2020-10-25 20:11:12 UTC

Git commit be263a1de29218cb993dd3c7b849f9ec6fee446f by Maik Qualmann.
Committed on 25/10/2020 at 20:09.
Pushed by mqualmann into branch 'master'.

better solution for the move dir problem

M  +3    -3    core/libs/iojobs/iojob.cpp

https://invent.kde.org/graphics/digikam/commit/be263a1de29218cb993dd3c7b849f9ec6fee446f