Bug 427842

Summary: Autoconf-based dependencies currently ignore the Android ABI architecture
Product: [Applications] krita Reporter: amyspark <amy>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: major    
Priority: NOR    
Version First Reported In: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Android   
OS: Android 9.x   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description amyspark 2020-10-16 21:51:02 UTC
SUMMARY

As logged on https://binary-factory.kde.org/job/Krita_Android_arm64-v8a_Dependency_Build/lastBuild/consoleFull , the 3rdparty toolchain does not forward the Android ABI target to Autoconf-based dependencies.

This bug does not currently cause any issues because the involved dependency, libiconv, is not found by exiv2; if one fixes that by setting CMAKE_FIND_ROOT_PATH, the dependency build will correctly detect a mismatch between libiconv.so and libexiv's archs and fail at link time.

STEPS TO REPRODUCE
1. Locally, run the androidbuild.sh script to start the dependency build.

OBSERVED RESULT

Dependency build improperly completes.

EXPECTED RESULT

Dependency build should fail.


SOFTWARE/OS VERSIONS
Windows: N/A
macOS: N/A
Linux/KDE Plasma: N/A
(available in About System)
KDE Plasma Version: B/A
KDE Frameworks Version: N/A 
Qt Version: N/A

ADDITIONAL INFORMATION

Using Android NDK r18b with the following environment variables:
"ANDROID_ABI": "armeabi-v7a",
"ANDROID_API_LEVEL": "21",
"PATH": "/opt/android-studio/jre/bin:${env:PATH}",
"ANDROID_NDK": "${env:HOME}/Android/Sdk/ndk/18.1.5063045/",
"ANDROID_NDK_ROOT": "${env:HOME}/Android/Sdk/ndk/18.1.5063045/",
"ANDROID_HOME": "${env:HOME}/Android/Sdk/ndk/18.1.5063045/",       
"ANDROID_SDK_ROOT": "${env:HOME}/Android/Sdk/",
"CMAKE_ANDROID_NDK": "${env:HOME}/Android/Sdk/ndk/18.1.5063045/"
Comment 1 Bug Janitor Service 2020-10-17 13:47:07 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/539