Bug 427814

Summary: Problem with localization of KFormat
Product: [Frameworks and Libraries] frameworks-kcoreaddons Reporter: Claudius Ellsel <claudius.ellsel>
Component: generalAssignee: Michael Pyne <mpyne>
Status: CONFIRMED ---    
Severity: normal CC: aspotashev, bizyaev, kdelibs-bugs, nate, oleg, s404.gordon, trufanovan, zawertun
Priority: NOR    
Version: 6.0.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Claudius Ellsel 2020-10-16 15:24:58 UTC
SUMMARY
See https://bugs.kde.org/show_bug.cgi?id=407179#c14.

Just based on that comment, not tested or anything else. I just wanted to file this bug, so people are aware and it doesn't get forgotten.
Comment 1 Evgeny 2020-11-11 18:57:36 UTC
Yes, can confirm.

In kinfocenter (and systemsettings) copied text contains Russian "ГиБ" instead of "GiB" when clicked on "Copy to clipboard in English" with LANGUAGE=ru_RU

For example:

Operating System: Manjaro Linux
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Kernel Version: 5.9.6-2-MANJARO
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 15.6 ГиБ of RAM
Graphics Processor: Radeon RX 590 Series
Comment 2 Claudius Ellsel 2020-11-11 19:51:46 UTC
I'll mark as confirmed.

Also I just had some deeper look. It seems that the `tr()` functions used there do not care about what locale is set in the constructor and thus this (https://invent.kde.org/plasma/kinfocenter/commit/97b66813bcfaeec046fc36dd4f5a8021b2a55264#5aca3766abfc10c651502c19c616a3de8dedbee7_48_47) does not work as intended?

https://invent.kde.org/frameworks/kcoreaddons/-/blob/master/src/lib/util/kformatprivate.cpp#L285
Comment 3 Claudius Ellsel 2020-11-11 20:07:11 UTC
One problem is that I don't really know what the locale parameter (https://invent.kde.org/frameworks/kcoreaddons/-/blob/master/src/lib/util/kformatprivate.cpp#L19) was thought for initially. It currently is used for some stuff, but not for things like string localization.

So the question would be whether it is intended to use it for that kind of purpose or whether one has to introduce a different parameter for that.

Also linking to the tr() documentation as I did not know about that before: https://doc.qt.io/qt-5/qobject.html#tr
Comment 4 Harald Sitter 2024-01-30 12:00:06 UTC
*** Bug 480534 has been marked as a duplicate of this bug. ***
Comment 5 Yaroslav Sidlovsky 2024-04-07 11:02:14 UTC
Problem still persist with version 6.0.0:
```
Operating System: Fedora Linux 40
KDE Plasma Version: 6.0.3
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.8.4-300.fc40.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 5700X 8-Core Processor
Memory: 31.2 ГиБ of RAM
Graphics Processor: NVIDIA GeForce RTX 3070/PCIe/SSE2
Manufacturer: ASUS
```

Note `ГиБ` appears in text.
Comment 6 Oleg 2024-06-29 21:09:58 UTC
Can confirm on 6.1.1

Operating System: Arch Linux 
KDE Plasma Version: 6.1.1
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.2
Kernel Version: 6.9.7-2-cachyos (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-7700K CPU @ 4.20GHz
Memory: 15.6 ГиБ of RAM
Graphics Processor: AMD Radeon RX 6700 XT