| Summary: | KDEConnect crush on notification | ||
|---|---|---|---|
| Product: | [Applications] kdeconnect | Reporter: | Misha <misha10311> |
| Component: | common | Assignee: | Albert Vaca Cintora <albertvaka> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | nicolas.fella |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/knotifications/commit/c58ac88593e2e4d8cb7137d787fdbc0269dd7e36 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Misha
2020-10-14 19:34:22 UTC
Judging by the backtrace you clicked on the notification before it crashed. Do you remember if you clicked on a specific action or just the notification itself? Also, what desktop are you using? I have an idea what is going on, but I haven't tried to reproduce it yet (In reply to Nicolas Fella from comment #1) > Judging by the backtrace you clicked on the notification before it crashed. > Do you remember if you clicked on a specific action or just the notification > itself? > > Also, what desktop are you using? > > I have an idea what is going on, but I haven't tried to reproduce it yet Just clicked on the notification from Telegram I'm using Fedora 32 with LXDE desktop Thanks! I was able to reproduce the problem in a Fedora LXDE VM and it seems to match my suspicion. There seems to be some difference in how the notifications are implemented in Plasma and LXDE which is why I haven't experienced the problem on Plasma. It should be easy to fix though A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/333 Thank you very much for fixing! A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knotifications/-/merge_requests/13 Git commit c58ac88593e2e4d8cb7137d787fdbc0269dd7e36 by Nicolas Fella. Committed on 15/10/2020 at 20:43. Pushed by nicolasfella into branch 'master'. Apply some sanity checking to action keys In case the notification server sends invalid actions don't forward them to the application. For example LXDE sends ActionInvoked for the default action even when no default action has been declared. M +9 -2 src/notifybypopup.cpp https://invent.kde.org/frameworks/knotifications/commit/c58ac88593e2e4d8cb7137d787fdbc0269dd7e36 |