Bug 427690

Summary:	System Tray widget has no padding between icons at 24px panel thickness
Product:	[Plasma] plasmashell	Reporter:	Keith <keithhacks-kdebug>
Component:	System Tray widget	Assignee:	Nate Graham <nate>
Status:	RESOLVED FIXED
Severity:	normal	CC:	leondeandrade, nate
Priority:	VHI	Keywords:	regression
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/8e3de778c666adf3b9f6b94ed5ddc7369ebad32c	Version Fixed/Implemented In:	5.20.1
Sentry Crash Report:
Attachments:	Normal Looking 22px No spacing 24px

Description Keith 2020-10-14 12:47:19 UTC

SUMMARY
System Tray no longer has spacing between icons when a panel has a height of 24px. (I can't make it any larger because my screen resolution is quite low.)

STEPS TO REPRODUCE
1. Update to the latest version of KDE.
2. Create a top panel with a height of 24px.
3. Add a System Tray.

OBSERVED RESULT
The icons are placed right up against each other with no padding.

EXPECTED RESULT
The widget's appearance should not induce projectile vomiting.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.20.0
(available in About System)
KDE Plasma Version: 5.20.0
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2020-10-16 14:30:06 UTC

Can you attach a screenshot?

> The widget's appearance should not induce projectile vomiting.
Please be polite in bug reports.

Comment 2 Leon De Andrade 2020-10-16 14:58:40 UTC

Created attachment 132425 [details]
Normal Looking 22px

Comment 3 Leon De Andrade 2020-10-16 14:59:02 UTC

Created attachment 132426 [details]
No spacing 24px

Comment 4 Leon De Andrade 2020-10-16 14:59:46 UTC

Can reproduce, the spacing is odd with 24px but fine with 22px and 26px

Comment 5 Nate Graham 2020-10-16 16:03:43 UTC

Can confirm. Will fix.

Comment 6 Nate Graham 2020-10-16 17:32:59 UTC

I bet this is a case of > needing to be >= or something...

Comment 7 Keith 2020-10-16 18:42:03 UTC

(In reply to Nate Graham from comment #1)
> > The widget's appearance should not induce projectile vomiting.
> Please be polite in bug reports.

I apologize, that was not intended to come off as rude.

Comment 8 Nate Graham 2020-10-16 18:43:27 UTC

Thanks, no hard feelings. :)

Comment 9 Nate Graham 2020-10-16 18:43:47 UTC

Git commit afd1b432c2e6ca7526e36080502237486725c728 by Nate Graham.
Committed on 16/10/2020 at 18:41.
Pushed by ngraham into branch 'master'.

[applets/systemtray] Fix icon size for 24px panels

We were using a > when we should have been using a >=, so there was one
panel thickness that would make icons be too large for their panel and
get squeezed together uncomfortably.
FIXED-IN: 5.20.1

M  +1    -1    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/afd1b432c2e6ca7526e36080502237486725c728

Comment 10 Nate Graham 2020-10-16 18:47:03 UTC

Git commit 8e3de778c666adf3b9f6b94ed5ddc7369ebad32c by Nate Graham.
Committed on 16/10/2020 at 18:46.
Pushed by ngraham into branch 'Plasma/5.20'.

[applets/systemtray] Fix icon size for 24px panels

We were using a > when we should have been using a >=, so there was one
panel thickness that would make icons be too large for their panel and
get squeezed together uncomfortably.
FIXED-IN: 5.20.1
(cherry picked from commit afd1b432c2e6ca7526e36080502237486725c728)

M  +1    -1    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/8e3de778c666adf3b9f6b94ed5ddc7369ebad32c