Bug 427553

Summary: ShadowedRectangle has pixellated corners in low power mode
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Noah Davis <noahadvs>
Component: generalAssignee: Arjen Hiemstra <ahiemstra>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Pixellated corners with radius of 3
Pixellated corners with radius of height/2

Description Noah Davis 2020-10-11 19:19:48 UTC
Created attachment 132279 [details]
Pixellated corners with radius of 3

STEPS TO REPRODUCE
1. Run a program that uses rounded shadowed rectangles with `KIRIGAMI_LOWPOWER_HARDWARE=1`

OBSERVED RESULT
Corners are not smooth

EXPECTED RESULT
Corners should be reasonably smooth

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20201007
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
Kernel Version: 5.8.4-1-default
OS Type: 64-bit
Processors: 4 × Intel® Core™ i7-6500U CPU @ 2.50GHz
Memory: 7.6 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 520
Comment 1 Noah Davis 2020-10-11 19:20:21 UTC
Created attachment 132280 [details]
Pixellated corners with radius of height/2
Comment 2 Arjen Hiemstra 2020-11-10 17:51:46 UTC
Git commit 1f6a16a2fa41d34525ef60bf92aa24e83a141320 by Arjen Hiemstra.
Committed on 10/11/2020 at 13:49.
Pushed by ahiemstra into branch 'master'.

Use fwidth() for smoothing in low power mode

Otherwise line sizes are different between small and larger items. In
addition, this makes low power behave more like normal mode and improves
the smoothing of the rendered result.

M  +2    -1    src/scenegraph/shaders/sdf_lowpower.glsl

https://invent.kde.org/frameworks/kirigami/commit/1f6a16a2fa41d34525ef60bf92aa24e83a141320