Bug 427337

Summary: Crash when rebuilding thumbnails or fingerprints
Product: [Applications] digikam Reporter: thebraincoral
Component: Database-ThumbsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: caulier.gilles, metzpinguin, pepejim
Priority: NOR    
Version First Reported In: 7.1.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In: 7.3.0
Sentry Crash Report:

Description thebraincoral 2020-10-04 19:51:38 UTC
SUMMARY


STEPS TO REPRODUCE
1. Attempt to use Tools > Maintenance > Rebuild Thumbnails or Fingerprints, database type (sqlite or mysql(internal) does not matter; uncheck box to allow full scann
2. 
3. 

OBSERVED RESULT
Application window crashes anywhere from a few seconds to few minutes after initiating scan.  Attempts to click elements to determine status of scan results in crash.

EXPECTED RESULT
Complete rebuild of thumbnails and fingerprints.

SOFTWARE/OS VERSIONS
Windows: 10.0.19041 (2004)
macOS: N/A
Linux/KDE Plasma: N/A
(available in About System)
KDE Plasma Version: N/A
KDE Frameworks Version: N/A
Qt Version: N/A

ADDITIONAL INFORMATION
Downgrade to digiKam 7.0 allowed rebuild of thumbnails and fingerprints to proceed.
Comment 1 Maik Qualmann 2020-10-04 20:09:47 UTC
Please try digiKam-7.2.0-beta1 from here:

https://files.kde.org/digikam/

Maik
Comment 2 Maik Qualmann 2020-11-11 13:35:03 UTC
*** Bug 428964 has been marked as a duplicate of this bug. ***
Comment 3 caulier.gilles 2020-11-11 14:15:43 UTC
Maik, 

I think it's the same here that the famous crash about threadimageio and thumbnails. It's due to copyable polymorphic class proble not resolved in HarrIface. Look this Clazy warning:

/home/gilles/Devel/7.x/core/libs/database/haar/haariface.h:50:1: warning: Polymorphic class Digikam::HaarProgressObserver is copyable. Potential slicing. [-Wclazy-copyable-polymorphic]
class HaarProgressObserver

There are also plenty of similar issues about DMetadata, MetaEngine, DRawDecodingSettings, DRawDecoding, etc. We need to fix these problems first, else we will seen again strange crashes for a long time.

Gilles
Comment 4 caulier.gilles 2020-11-12 13:39:58 UTC
Git commit 8a2eba8bdfd2cdb8972ecee31bfaa1122e5b65f6 by Gilles Caulier.
Committed on 12/11/2020 at 13:37.
Pushed by cgilles into branch 'master'.

Clazy++ : fix copy constructor warning with internal polymorphic class used in HarrIface
Related: bug 428964

M  +2    -1    core/libs/database/dbjobs/duplicatesprogressobserver.cpp
M  +8    -2    core/libs/database/haar/haariface.h
M  +6    -6    core/libs/database/haar/haariface_p.cpp

https://invent.kde.org/graphics/digikam/commit/8a2eba8bdfd2cdb8972ecee31bfaa1122e5b65f6
Comment 5 caulier.gilles 2021-03-30 06:53:28 UTC
digiKam 7.2.0 official release is published with more than 360 files closed from bugzilla:

https://www.digikam.org/news/2021-03-22-7.2.0_release_announcement/

Can you reproduce the dysfunction with this version ?

Thanks in advance for your feedback

Gilles Caulier
Comment 6 thebraincoral 2021-06-10 19:40:10 UTC
Downloaded 7.2.0, reproduced steps, no crash occurred.  Thank you :-)