| Summary: | URL hints broken | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Martin Sandsmark <martin.sandsmark> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | nate, tcanabrava |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/konsole/commit/88f2462e6440fbe0974d597985c0e59f3cca3382 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Martin Sandsmark
2020-10-03 13:39:36 UTC
CCing Tomaz, since I think it happened during the refactoring. I'll see if I figure it out, but just in case you already know where the issue is. Do clarify, 0 doesn't work? and all the other do? If you hold down the modifier shortcuts, the hint at the bottom used to be 1, so the hints would start on the left side on the keyboard, and increase to the right. So the first regression is that it now starts at 0. And if you then press whatever-modifiers-you-have-set and 0, it doesn't open the URL, but the others do work. And it's probably related. From a bisect: 28e1a3e634236bf271cab8fa7ef4178656c9f506 is the first bad commit commit 28e1a3e634236bf271cab8fa7ef4178656c9f506 Author: Tomaz Canabrava <tcanabrava@kde.org> Date: Wed Sep 16 12:24:28 2020 +0100 Correctly fix reverse url numering src/filterHotSpots/FilterChain.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) From the commit message and content I think it's just a misunderstanding (and not comparing the behavior against the original implementation). I'll submit a patch on gitlab. A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/234 Git commit 88f2462e6440fbe0974d597985c0e59f3cca3382 by Kurt Hindenburg, on behalf of Martin T. H. Sandsmark. Committed on 06/10/2020 at 14:09. Pushed by hindenburg into branch 'master'. Revert "Correctly fix reverse url numering" The previous behavior was actually the intended one, the URL hints are intended to strictly increase from start to finish (physically on the keyboard). It might not be "technically" correct, but that's the original behavior before the refactor (and I think it makes the most sense, that's why I implemented it that way originally). Also fixes activating the first URL, activating 0 didn't work. This reverts commit 28e1a3e634236bf271cab8fa7ef4178656c9f506. M +6 -9 src/filterHotSpots/FilterChain.cpp https://invent.kde.org/utilities/konsole/commit/88f2462e6440fbe0974d597985c0e59f3cca3382 |