Bug 427259

Summary: Have ECMAddAppIcon generate Windows icons automatically from the SVG
Product: [Frameworks and Libraries] extra-cmake-modules Reporter: Dawid Wróbel <me>
Component: generalAssignee: ecm-bugs-null <ecm-bugs-null>
Status: REPORTED ---    
Severity: wishlist CC: vonreth
Priority: NOR    
Version First Reported In: 5.74.0   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Dawid Wróbel 2020-10-02 16:55:13 UTC 
SUMMARY
ECMAddAppIcon can use SVG icon on macOS, since macOS supports it natively. 

Windows, however, requires a set of the PNG icons explicitly provided before they are converted into .ico using icotool. 

This process, however, can be automated, releasing users from having to provide the PNG file and instead letting SVG be enough for both platforms.

See the following Makefile change that does that automatically for octave:  http://hg.savannah.gnu.org/hgweb/octave/rev/1687269e31e4


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Christophe Marin 2020-10-02 17:03:12 UTC 
Hannah, what do you think about this?
Comment 2 Hannah von Reth 2020-10-02 18:49:42 UTC 
We are using icoutils icotool which don't support svg input... 
So yes we probably need to add a step to convert the svg to png first.
Craft should probably provide svg2ico or something similar.
Comment 3 Dawid Wróbel 2020-10-02 19:13:52 UTC 
Hannah, the referenced Octave Makefile uses rsvg-convert for the purpose of svg2png conversion.