Bug 426968

Summary: Album title bar in icon view should be a selection switch
Product: [Applications] digikam Reporter: Jo <jo.y.venn>
Component: Albums-IconViewAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles, maeseee, mdhull07, metzpinguin
Priority: NOR Flags: caulier.gilles: Junior_Jobs+
Version: 7.0.0   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/89de517a7701fb18f2fd99d5bd74d7af6e390dbe Version Fixed In: 8.5.0
Sentry Crash Report:

Description Jo 2020-09-25 18:28:38 UTC 
SUMMARY
The title bar (with directory path and Album date information) of the grid view allows to select all visible pictures 

STEPS TO REPRODUCE
1. Click the title bar of the grid view 
2. All visible images will be selected 
3. Click again, and Digikam selects again all selected visible images 

OBSERVED RESULT
Clicking a second time on the title bar of the grid view should deselect pictures instead to select them, re-selection of already selected pictures simply makes no sense. 

EXPECTED RESULT
Click one time on the tile bar of the grid view to select, click another time to deselect items, click again to select them again, etc.. 

SOFTWARE/OS VERSIONS
macOS: 10.14.6
Comment 1 Marcel 2020-09-28 15:35:48 UTC 
Vishal,
according to your question, I would start looking in the class itemcategorydrawer.cpp file. There is the place where the title bar is set up.

About this whole bug report. In my opinion it is not a bug. The current solution is a state less user interface what makes it much less error prune. I don't know any program that deselects all items after pressing Ctrl + A a second time.
Comment 2 vishal 2020-09-28 17:32:17 UTC 
(In reply to Marcel from comment #1)
> Vishal,
> according to your question, I would start looking in the class
> itemcategorydrawer.cpp file. There is the place where the title bar is set
> up.
> 
> About this whole bug report. In my opinion it is not a bug. The current
> solution is a state less user interface what makes it much less error prune.
> I don't know any program that deselects all items after pressing Ctrl + A a
> second time.

I think ctrl+shift+A is used in code to unselect after ctrl A selection
Comment 3 Maik Qualmann 2020-09-28 18:48:17 UTC 
Unfortunately I don't find a program example to see how others have implemented it. I'm not sure I would tend to leave it as it is now.

Maik
Comment 4 caulier.gilles 2024-09-19 08:34:34 UTC 
Maik,

where is the code to caught the mouse click on the album header ?

Gilles
Comment 5 Maik Qualmann 2024-09-19 19:48:19 UTC 
Git commit 89de517a7701fb18f2fd99d5bd74d7af6e390dbe by Maik Qualmann.
Committed on 19/09/2024 at 19:47.
Pushed by mqualmann into branch 'master'.

implement item selection switcher for the category header
FIXED-IN: 8.5.0

M  +1    -1    NEWS
M  +18   -4    core/libs/widgets/itemview/dcategorizedview.cpp
M  +1    -0    core/libs/widgets/itemview/dcategorizedview_p.h

https://invent.kde.org/graphics/digikam/-/commit/89de517a7701fb18f2fd99d5bd74d7af6e390dbe