Bug 426916

Summary: Assigned shortcut doesn't work
Product: [Applications] krita Reporter: Danilo JR <danilojunior>
Component: Tools/SelectionAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, dimula73
Priority: NOR Keywords: regression
Version: 4.4.0-beta1   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:

Description Danilo JR 2020-09-23 22:33:27 UTC
SUMMARY

I assigned a shortcut to Polygonal Selection Tool and It didn't work. The shortcut get assigned but It simply doesn't work. It's happening just to this tool.

STEPS TO REPRODUCE
1. Settings>Configure Krita>keyboard shortcuts
2. Search>Polygonal Selection Tool>Custom shortcut
3. Try the shortcut

OBSERVED RESULT
Nothing, Nada!

EXPECTED RESULT
Polygonal Selection Tool

SOFTWARE/OS VERSIONS
Windows: W7SP1 Ultimate x64
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Ahab Greybeard 2020-09-24 15:32:35 UTC
I can confirm this for the 4.4.0-beta1 and the 23Sept 4.4.1 alpha (git 604b2ce) appimages.
(The 4.3.0 appimage does not have the problem.)

If you try to assign a shortcut to the Polygonal Selection Tool, it is apparently accepted but the shortcut is not shown in the tool tip and the shortcut key has no effect.
If you then try to assign the same shortcut to another function, there is a warnng that it's already assigned to the Polygonal Selection tool.
Comment 2 Dmitry Kazakov 2020-09-24 20:55:11 UTC
Git commit 71fabd05cdb64a1f06b7b604b2aaa53b5b6d92b8 by Dmitry Kazakov.
Committed on 24/09/2020 at 20:55.
Pushed by dkazakov into branch 'krita/4.3'.

Fix shortcut for Polygonal Selection Tool

Regression from 10 Jun 2020:
5b41b826fb1d4fe8faf9a8d15b4def762dd468bc

M  +1    -1    plugins/tools/selectiontools/KisToolSelectPolygonal.action

https://invent.kde.org/graphics/krita/commit/71fabd05cdb64a1f06b7b604b2aaa53b5b6d92b8
Comment 3 Dmitry Kazakov 2020-09-24 20:55:29 UTC
Git commit 9e139a0ffc928b468b911dbbc9fbd820af755ca8 by Dmitry Kazakov.
Committed on 24/09/2020 at 20:55.
Pushed by dkazakov into branch 'master'.

Fix shortcut for Polygonal Selection Tool

Regression from 10 Jun 2020:
5b41b826fb1d4fe8faf9a8d15b4def762dd468bc

M  +1    -1    plugins/tools/selectiontools/KisToolSelectPolygonal.action

https://invent.kde.org/graphics/krita/commit/9e139a0ffc928b468b911dbbc9fbd820af755ca8
Comment 4 Dmitry Kazakov 2020-09-24 20:56:02 UTC
Git commit 612b65aef14f5f295dfc1a3868bb7cdf78c74351 by Dmitry Kazakov.
Committed on 24/09/2020 at 20:55.
Pushed by dkazakov into branch 'krita/4.4.0'.

Fix shortcut for Polygonal Selection Tool

Regression from 10 Jun 2020:
5b41b826fb1d4fe8faf9a8d15b4def762dd468bc

M  +1    -1    plugins/tools/selectiontools/KisToolSelectPolygonal.action

https://invent.kde.org/graphics/krita/commit/612b65aef14f5f295dfc1a3868bb7cdf78c74351