Bug 426867

Summary:	Color picker color squares don't hide when action is over
Product:	[Applications] krita	Reporter:	Wojtek Trybus <wojtryb>
Component:	OpenGL Canvas	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73, griffinvalley, halla
Priority:	NOR	Keywords:	regression
Version:	4.4.0-beta1
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/8aa9e1b27891d997db787bfc20026d061d44bfa3	Version Fixed In:
Sentry Crash Report:

Description Wojtek Trybus 2020-09-22 12:19:08 UTC

SUMMARY
the pixels on which color squares (active and picked color) were displayed don't update when the color picking action is over. You need to hover over those areas to force it's update. Sometimes it updated in the middle of a stroke.
Once I managed to make it not appear at all until restart, but couldn't recreate it.

STEPS TO REPRODUCE
1. Pick a color from canvas with ctrl+LMB

OBSERVED RESULT
Two color squares stay visible after the ctrl is released

EXPECTED RESULT
color squares hide immediately after the action

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Kubuntu 20.04
(available in About System)
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8

ADDITIONAL INFORMATION
I own QHD display - I believe something was done with canvas tiles updating on larger than HD screens.

Comment 1 Halla Rempt 2020-09-22 12:20:08 UTC

Hm, I cannot reproduce that.

Comment 2 wolthera 2020-09-22 12:21:22 UTC

Actually a opengl canvas problem. I'm assigning dmitry.

I cannot confirm, because on master I have a different problem: I can't see the squares :D

Comment 3 Dmitry Kazakov 2020-09-23 20:48:55 UTC

I can reproduce it on Linux only. It looks like it somehow depends on the way Qt is patched for partial updates.

Comment 4 Dmitry Kazakov 2020-09-24 09:23:36 UTC

Git commit 9defcc2243e60c5f8a19fa94bd5409c0adf95e5c by Dmitry Kazakov.
Committed on 24/09/2020 at 09:23.
Pushed by dkazakov into branch 'krita/4.3'.

Fix updates of color picker's preview

Originally, colorPreviewDocUpdateRect has just never been assigned
with anything, so no updates happened. The patch fixes updates for
both picked and base color previews.

M  +25   -10   libs/ui/tool/kis_tool_paint.cc
M  +2    -1    libs/ui/tool/kis_tool_paint.h

https://invent.kde.org/graphics/krita/commit/9defcc2243e60c5f8a19fa94bd5409c0adf95e5c

Comment 5 Dmitry Kazakov 2020-09-24 09:24:13 UTC

Git commit 0cf0db83a673247712f25aa197a39d9c6e33fd07 by Dmitry Kazakov.
Committed on 24/09/2020 at 09:24.
Pushed by dkazakov into branch 'krita/4.4.0'.

Fix updates of color picker's preview

Originally, colorPreviewDocUpdateRect has just never been assigned
with anything, so no updates happened. The patch fixes updates for
both picked and base color previews.

M  +25   -10   libs/ui/tool/kis_tool_paint.cc
M  +2    -1    libs/ui/tool/kis_tool_paint.h

https://invent.kde.org/graphics/krita/commit/0cf0db83a673247712f25aa197a39d9c6e33fd07

Comment 6 Dmitry Kazakov 2020-09-24 09:24:57 UTC

Git commit 8aa9e1b27891d997db787bfc20026d061d44bfa3 by Dmitry Kazakov.
Committed on 24/09/2020 at 09:24.
Pushed by dkazakov into branch 'master'.

Fix updates of color picker's preview

Originally, colorPreviewDocUpdateRect has just never been assigned
with anything, so no updates happened. The patch fixes updates for
both picked and base color previews.

M  +25   -10   libs/ui/tool/kis_tool_paint.cc
M  +2    -1    libs/ui/tool/kis_tool_paint.h

https://invent.kde.org/graphics/krita/commit/8aa9e1b27891d997db787bfc20026d061d44bfa3