| Summary: | KStyle Breeze uses a wrong KColorScheme for Button colors focus and hover | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Jaakko Kantojärvi <jaakko> |
| Component: | QStyle | Assignee: | Janet Blackquill <uhhadd> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, noahadvs, uhhadd |
| Priority: | NOR | ||
| Version: | 5.17.5 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze/commit/dd3b18930e08638e27eeff7e382a3854036140b6 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Jaakko Kantojärvi
2020-09-17 19:17:22 UTC
Noah and Carson, any thoughts on this? Seems like something to fix. Will add to my to-do list for tomorrow. <3 I have been using different colors for different color sets, so I can see which locations use what colors for past few days. I think one challenge is that there is only decoration colors and not focus and hover background colors. To me, the decoration colors seem to be more highlight colors and not suitable for the background. However, the Breeze requires background highlight colors too, which is good for the look'n'feel of course. For example, selecting a nice bright (high contrast) color for the hover effect, makes the contrast low when it's used as a background (bright color behind bright text), as you can see in the video in shared imgur post [1]. The Plasma panel seems to use the decoration color for the edge as expected, but it also uses a darkened version of the color for the background (see image 2 in [1]), thus kind of fixing the issue. Should the same be done here too? Or should we blend/mix the decoration color with the background color? That could mean that if the background color is white and text is black, the resulting background still yield a good contrast for the text?. As a side note, the panel uses correct color set for buttons. I guess the best would be adding background colors for hover and focus cases in the color set, but I guess that would be way harder or more complicated to change than working with the current color sets. [1]: https://imgur.com/a/ED6VD9D p.s. I was working on with a generic color scheme, so I could give a list of major colors and get a list of color shemes out, which would mimic the "highlight" color feature from other operating systems. A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/31 Git commit 659e3d35dca93b600b1492b653ea641e5158824f by Carson Black. Committed on 21/09/2020 at 20:21. Pushed by cblack into branch 'master'. [kstyle]: Make buttons use KColorScheme::Button for hover and focus colours M +13 -11 kstyle/breezehelper.cpp M +10 -0 kstyle/breezehelper.h https://invent.kde.org/plasma/breeze/commit/659e3d35dca93b600b1492b653ea641e5158824f Git commit dd3b18930e08638e27eeff7e382a3854036140b6 by Nate Graham, on behalf of Carson Black. Committed on 21/09/2020 at 20:38. Pushed by ngraham into branch 'Plasma/5.20'. [kstyle]: Make buttons use KColorScheme::Button for hover and focus colours (cherry picked from commit 659e3d35dca93b600b1492b653ea641e5158824f) M +13 -11 kstyle/breezehelper.cpp M +10 -0 kstyle/breezehelper.h https://invent.kde.org/plasma/breeze/commit/dd3b18930e08638e27eeff7e382a3854036140b6 |