| Summary: | Flatpak: Refuses to remove a faulty remote | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Flatpak Backend | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | adamw, aleixpol, jgrulich, nate |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| URL: | https://github.com/flatpak/flatpak/issues/3862 | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/commit/0f2f62b8412892df23787439c1d1cd4a5b6eeb83 | Version Fixed In: | 5.23.1 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2020-09-15 14:55:27 UTC
Can reproduce. Adding https://dl.winepak.org/repo/winepak.flatpakrepo as a repo and then deleting it makes Discover crash. I can't reproduce with other repos though. Just https://dl.winepak.org/repo/winepak.flatpakrepo. It is crashing in toRemoveHash.reserve(refs->len); refs->len seems to be invalid; even trying to print its value crashes Discover. Git commit de93217a1f2f5a38f3699fa07a7b6818d80fe252 by Aleix Pol. Committed on 16/09/2020 at 01:35. Pushed by apol into branch 'master'. flatpak: Don't crash if we try to remvoe a fautly remote Instead of returning an empty list, it returns a nullptr. Account for that. M +55 -51 libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp https://invent.kde.org/plasma/discover/commit/de93217a1f2f5a38f3699fa07a7b6818d80fe252 I managed to reproduce and fix the crash. Now we get an error message that the repository could not be removed. I have the impression that it's an issue in libflatpak, so I reported it there. Error I get: FlatpakSourcesBackend::removeSource|?libDiscoverCommon.so?|AbstractSourcesBackend::qt_metacall could not list refs in repo "winepak" Signature made Fri Jul 20 04:30:34 2018 using RSA key ID A959831C080B608F BAD signature from " <julian@richen.io>" Key expired Tue Jun 9 20:16:34 2020 (process:93795): OSTree-CRITICAL **: 03:31:49.130: ostree_repo_open: assertion 'error == NULL || *error == NULL' failed https://github.com/flatpak/flatpak/issues/3862 Today Discover 5.20 beta crashed on Arch Linux when I removed Gnome Nightly repo. https://wiki.gnome.org/Apps/Nightly Git commit 97b1a4530c03e84208799786d158a0331dd5ec40 by Aleix Pol Gonzalez, on behalf of Aleix Pol. Committed on 18/10/2021 at 21:52. Pushed by apol into branch 'master'. flatpak: Don't reuse GError instances It might already be filled and that makes libostree to assert out when it's the case. M +3 -2 libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp https://invent.kde.org/plasma/discover/commit/97b1a4530c03e84208799786d158a0331dd5ec40 Git commit 0f2f62b8412892df23787439c1d1cd4a5b6eeb83 by Aleix Pol Gonzalez, on behalf of Aleix Pol. Committed on 18/10/2021 at 21:53. Pushed by apol into branch 'Plasma/5.23'. flatpak: Don't reuse GError instances It might already be filled and that makes libostree to assert out when it's the case. (cherry picked from commit 97b1a4530c03e84208799786d158a0331dd5ec40) M +3 -2 libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp https://invent.kde.org/plasma/discover/commit/0f2f62b8412892df23787439c1d1cd4a5b6eeb83 *** Bug 443455 has been marked as a duplicate of this bug. *** |