Bug 426403

Summary:	Imported .gpl palette disappear upon re-launch/re-open
Product:	[Applications] krita	Reporter:	pegasusearl
Component:	Resource Management	Assignee:	Halla Rempt <halla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley, halla
Priority:	NOR
Version First Reported In:	4.3.0
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	This is the gpl file I used for testing. From lospec website.

Description pegasusearl 2020-09-11 11:37:18 UTC

Created attachment 131560 [details]
This is the gpl file I used for testing. From lospec website.

Good day, I hope it's not a duplicate.

SUMMARY
Imported .gpl palette will:
1. Disappear upon re-launch if saved in current document.
2. Disappear upon re-opening project if not saved in current document.

STEPS TO REPRODUCE
1. Open krita, and open a project.
2. Import .gpl color palette to docker. Select no when asked to save in current document.
3. Close project without closing Krita
4. Poof! the imported palette is gone.

1. Open krita, and open a project.
2. Import .gpl color palette to docker. Select YES when asked to save in current document.
3. (Optional) draw something to allow saving. then save the project.
4. (Optional) Close project without closing Krita. The palette is still there.
5. Now re-launch krita and open the same project.
6. Poof! the imported palette is gone.


OBSERVED RESULT
If you export the imported .gpl palette to .kpl it actually create a .gpl file as file.kpl. It probably forgot to convert to kpl?


EXPECTED RESULT
It's supposed to stay.

SOFTWARE/OS VERSIONS
Linux: Manjaro Gnome
Krita 4.3.0

Example palette files to use:
https://lospec.com/palette-list/island-joy-16

Comment 1 wolthera 2020-09-11 11:48:25 UTC

Ok, I think I actually fixed this one for 4.4, can you check Krita:Plus from the website?

Comment 2 pegasusearl 2020-09-11 13:19:21 UTC

(In reply to wolthera from comment #1)
> Ok, I think I actually fixed this one for 4.4, can you check Krita:Plus from
> the website?

Krita 4.4.0-alpha git(c00326b)
The problem still present. The difference is now it does not ask me whether or not I want to save the palette to current document.
The behaviour is similar to when I select YES to 'save to current document'. The palette disappear on re-launch but still present if we re-open project.

Comment 3 pegasusearl 2020-09-11 13:25:04 UTC

while we are talking about palette docker, I also want to quote a post in the forum:

"reducing the number of columns and rows erases colours; they don’t re-organise themselves, but instead are fully gone."

or should it be separate bug report?

Comment 4 wolthera 2020-09-11 15:00:55 UTC

There's already a bugreport for that, but it'll take a bit more brainpower from me on how to solve that one as it's a case of bad design in general.

Comment 5 Halla Rempt 2021-04-08 08:42:29 UTC

This is fixed in master (tested with 66812ef4f7)