| Summary: | Notification changes its position on the screen when I open hamburger menu of Notifications applet | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bharadwaj.raju777, nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/64492d5812c89a4f502b8cdae6aa5a4960c8b56a | Version Fixed/Implemented In: | 5.27 |
| Sentry Crash Report: | |||
| Attachments: | screen recording | ||
Hah that's funny. Git commit bc12c6ca60331939c6070c93c63022368241d7c4 by Kai Uwe Broulik. Committed on 14/10/2020 at 07:37. Pushed by broulik into branch 'master'. [Notifications] Also check transient parent for whether it's a dialog In case a context menu is opened, we want to check the dialog it came from. This fixes the case of notifications dancing around when opening a context menu in System Tray but does not fix the case when opening a context menu in the notification itself since there it cannot know that the still open System Tray popup is the one we should evade and not the popup with the menu in it. M +10 -1 applets/notifications/notificationapplet.cpp https://invent.kde.org/plasma/plasma-workspace/commit/bc12c6ca60331939c6070c93c63022368241d7c4 Git commit 684bc80657e4ccaf52aed6426e8d80d1d475742d by Kai Uwe Broulik. Committed on 14/10/2020 at 07:41. Pushed by broulik into branch 'Plasma/5.20'. [Notifications] Also check transient parent for whether it's a dialog In case a context menu is opened, we want to check the dialog it came from. This fixes the case of notifications dancing around when opening a context menu in System Tray but does not fix the case when opening a context menu in the notification itself since there it cannot know that the still open System Tray popup is the one we should evade and not the popup with the menu in it. (cherry picked from commit bc12c6ca60331939c6070c93c63022368241d7c4) M +10 -1 applets/notifications/notificationapplet.cpp https://invent.kde.org/plasma/plasma-workspace/commit/684bc80657e4ccaf52aed6426e8d80d1d475742d Seems this was also fixed with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2426 Git commit 64492d5812c89a4f502b8cdae6aa5a4960c8b56a by Nate Graham, on behalf of Bharadwaj Raju. Committed on 01/01/2023 at 00:36. Pushed by ngraham into branch 'master'. applets/notifications: Fix notifications jumping around when dialogs close or lose focus Keep around the last non-notification focused Plasma dialog, so we can maintain stable notification positioning even if we have a Plasma dialog which loses focus but stays visible (think pinned System Tray applets). This also fixes notifications jumping down on close, since now the dialog used to calculate the notification popups's offset is never itself a NotificationPopup. Related: bug 449085, bug 461492 FIXED-IN: 5.27 M +15 -7 applets/notifications/package/contents/ui/global/Globals.qml https://invent.kde.org/plasma/plasma-workspace/commit/64492d5812c89a4f502b8cdae6aa5a4960c8b56a |
Created attachment 131422 [details] screen recording SUMMARY Watch the attached screen recording please. EXPECTED RESULT notification should remain positioned above popup of Notifications applet when we open the hamburger menu. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.74.0 Qt Version: 5.14.2