Bug 426151

Summary: Remove not implemented settings option "Insert transaction type into No. field for new transactions"
Product: [Applications] kmymoney Reporter: Ralf Habacker <ralf.habacker>
Component: generalAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 4.8.4   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: https://invent.kde.org/office/kmymoney/commit/2bd3c0927562bd48cbf03844d86b36ec69c71655 Version Fixed In: 4.8.5,5.1.1
Sentry Crash Report:

Description Ralf Habacker 2020-09-03 16:23:03 UTC 
The mentioned option in the "data entry" tab of the ledger settings menu is not implemented and therefore should be removed.


STEPS TO REPRODUCE
1. git clone kmymoney source
2. search for 'CopyTypeToNr'

OBSERVED RESULT
The only references for the mentioned settings options are: 

grep -rni CopyTypeToNr *

  kmymoney/settings/kmymoney.kcfg:75:  <entry name="CopyTypeToNr" type="Bool">
  kmymoney/dialogs/settings/ksettingsregisterdecl.ui:191:                <widget class="QCheckBox" name="kcfg_CopyTypeToNr">

Setting options really used in the code needs at least three references as shown with the option 'AutoIncCheckNumber'

grep -rni autoIncCheckNumber *

  kmymoney/settings/kmymoney.kcfg:24:  <entry name="AutoIncCheckNumber" type="Bool">
  kmymoney/dialogs/settings/ksettingsregisterdecl.ui:198:                <widget class="QCheckBox" name="kcfg_AutoIncCheckNumber">
  kmymoney/dialogs/transactioneditor.cpp:1079:          && KMyMoneyGlobalSettings::autoIncCheckNumber()           // and auto inc number turned on?

EXPECTED RESULT
The unimplemented setting option should be removed

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Leap 15.1
KDE Frameworks Version: 5.55.0
Qt Version: 5.9.7

ADDITIONAL INFORMATION
All active branches are affected
Comment 1 Bug Janitor Service 2020-09-03 17:35:53 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/30
Comment 2 Ralf Habacker 2020-09-06 18:57:58 UTC 
Git commit fb1e20b15691e0855b59f26616c5abb2c14737d7 by Ralf Habacker.
Committed on 06/09/2020 at 18:56.
Pushed by habacker into branch '4.8'.

Remove not implemented settings option "Insert transaction type into No. field for new transactions"
FIXED-IN:4.8.5

M  +0    -9    doc/details-settings.docbook
M  +0    -7    kmymoney/dialogs/settings/ksettingsregisterdecl.ui
M  +0    -4    kmymoney/settings/kmymoney.kcfg

https://invent.kde.org/office/kmymoney/commit/fb1e20b15691e0855b59f26616c5abb2c14737d7
Comment 3 Ralf Habacker 2020-09-15 06:05:17 UTC 
Git commit 587f1614d4fc73908a98c05c5c7b9178aadccbae by Ralf Habacker.
Committed on 15/09/2020 at 06:04.
Pushed by habacker into branch '5.1'.

Remove not implemented settings option "Insert transaction type into No. field for new transactions
FIXED-IN:5.1.1

M  +0    -9    doc/details-settings.docbook
M  +0    -7    kmymoney/dialogs/settings/ksettingsregister.ui
M  +0    -4    kmymoney/settings/kmymoney.kcfg

https://invent.kde.org/office/kmymoney/commit/587f1614d4fc73908a98c05c5c7b9178aadccbae
Comment 4 Thomas Baumgart 2020-09-15 06:09:30 UTC 
Git commit 2bd3c0927562bd48cbf03844d86b36ec69c71655 by Thomas Baumgart.
Committed on 15/09/2020 at 06:09.
Pushed by tbaumgart into branch 'master'.

Remove not implemented settings option "Insert transaction type into No. field for new transactions
FIXED-IN:5.1.1

(cherry picked from commit 587f1614d4fc73908a98c05c5c7b9178aadccbae)

M  +0    -9    doc/details-settings.docbook
M  +0    -7    kmymoney/dialogs/settings/ksettingsregister.ui
M  +0    -4    kmymoney/settings/kmymoney.kcfg

https://invent.kde.org/office/kmymoney/commit/2bd3c0927562bd48cbf03844d86b36ec69c71655