Bug 426122

Summary:	redundant OSD indication when switching keyboard layout with Policy other than Global
Product:	[Plasma] kwin	Reporter:	Andrey <butirsky>
Component:	input	Assignee:	Andrey <butirsky>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aspotashev, null
Priority:	NOR	Flags:	butirsky: Wayland+ butirsky: X11-
Version First Reported In:	git master
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
URL:	https://invent.kde.org/plasma/kwin/-/merge_requests/210
See Also:	https://bugs.kde.org/show_bug.cgi?id=425590 https://bugs.kde.org/show_bug.cgi?id=426120 https://bugs.kde.org/show_bug.cgi?id=418699
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/db202f5c265d552ca8c908c72c1a46f9270b0291	Version Fixed/Implemented In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	418699

Description Andrey 2020-09-02 20:57:12 UTC

SUMMARY
Described the case with Application switching Policy.

STEPS TO REPRODUCE
1. Set Application Policy for keyboard layout switching in Keyboard Settings. Make sure there are at least 2 layouts.
2. Switch layout in one app, note OSD notification pop up on the switching.
3. Focus another app with mouse.
4. Start switching to the first app, now using Alt+Tab key combination. While pressing Alt+Tab, hold down Alt for a while, then Tab. 

OBSERVED RESULT
On Alt, OSD notification popup immediately even before the app switch.

EXPECTED RESULT
We are not interested in OSD for the previous app on app switching.

SOFTWARE/OS VERSIONS
Operating System: Ubuntu 20.04
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2

Comment 1 David Edmundson 2020-09-29 14:20:36 UTC

Git commit db202f5c265d552ca8c908c72c1a46f9270b0291 by David Edmundson, on behalf of Andrey Butirsky.
Committed on 29/09/2020 at 14:20.
Pushed by davidedmundson into branch 'master'.

fix: redundant keyboard layout OSD notification

there is no need to display the OSD for window we are going to switch from

DIGEST:

M  +2    -0    keyboard_input.cpp

https://invent.kde.org/plasma/kwin/commit/db202f5c265d552ca8c908c72c1a46f9270b0291