Bug 426065

Summary: Make all overlay sheets modal to the whole window, not the current view
Product: [Applications] Discover Reporter: Andres Betts <anditosan1000>
Component: discoverAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, nate
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/plasma/discover/commit/27a77073b7458d3bb461f3145b0bfb06ca7e0410 Version Fixed In: 5.20
Sentry Crash Report:

Description Andres Betts 2020-09-01 15:51:50 UTC 
SUMMARY
Popup windows should have a globalsheet property to look the same as the rest of popups in Discover. Even though the left menu is active and not darkened, this makes it visually inconsistent to the rest of popups within Discover.

At the same time, the interaction on the un-darkened section bears no changes to the popup window. Therefore, if there is no effect, it makes no difference in keeping looks consistent.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Differences shown in this post: https://pointieststick.com/2020/08/28/this-week-in-kde-tons-and-tons-and-tons-of-plasma-5-20-features-bugfixes-and-ui-improvements/
Comment 1 Bug Janitor Service 2020-09-08 17:59:58 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/31
Comment 2 Nate Graham 2020-09-09 15:37:09 UTC 
Git commit 27a77073b7458d3bb461f3145b0bfb06ca7e0410 by Nate Graham.
Committed on 09/09/2020 at 15:36.
Pushed by ngraham into branch 'master'.

Make all OverlaySheets window-modal

Right now half of Discover's OverlaySheets are view-modal and the other
half are window-modal. This feels arbitrary to the user, and view-modal
sheets look weird since the global drawer doesn't darken. This is
because it's still interactive, but there's really no point in being
able to interact with the global drawer while a sheet is open anyway. So
let's just make them all window-modal.
FIXED-IN: 5.20

M  +2    -0    discover/qml/AddonsView.qml
M  +0    -1    discover/qml/ApplicationPage.qml
M  +1    -0    discover/qml/ReviewDialog.qml
M  +3    -1    discover/qml/ReviewsPage.qml
M  +2    -0    discover/qml/SourcesPage.qml
M  +2    -0    discover/qml/UpdatesPage.qml

https://invent.kde.org/plasma/discover/commit/27a77073b7458d3bb461f3145b0bfb06ca7e0410